Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFTP Node: Breaking Change to $binary.data.fileName #6026

Closed
rhyswilliamsza opened this issue Apr 20, 2023 · 1 comment · Fixed by #6170
Closed

SFTP Node: Breaking Change to $binary.data.fileName #6026

rhyswilliamsza opened this issue Apr 20, 2023 · 1 comment · Fixed by #6170
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@rhyswilliamsza
Copy link
Contributor

rhyswilliamsza commented Apr 20, 2023

Describe the bug
We use the {{$binary.data.fileName}} property to reference binary files downloaded by the SFTP node. In 0.202.0, {{$binary.data.fileName}} was the actual file name. In 0.219.1, {{$binary.data.fileName}} no longer contains the original file name, it contains the file path of the original file.

To Reproduce
Steps to reproduce the behavior:

  1. Download a File using the SFTP Node
  2. Notice that $binary.data.fileName references the full path (e.g. /data/test/file.txt).

Expected behavior

  1. Download a File using the SFTP Node
  2. The $binary.data.fileName property should ideally display the fileName, not the full path (e.g. file.txt).

Environment (please complete the following information):

  • OS: All
  • n8n Version: v0.219.1
  • Node.js Version: All
  • Database system: MySQL
  • Operation mode: Queue

Additional context
I believe this may be an unintended side effect of #5296.

If this is expected behaviour or aligns with other nodes, we can make the move to changing our workflows. However just wanted to note the difference from the older version. Thanks!

@Joffcom
Copy link
Member

Joffcom commented Apr 20, 2023

Hey @rhyswilliamsza,

Thanks for reporting this one, I have an internal ticket which we are tracking as NODE-491

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants