Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Reduce the number of events sent to Sentry #6235

Merged
merged 2 commits into from
May 15, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented May 12, 2023

No description provided.

@netroy netroy requested a review from krynble May 12, 2023 09:32
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 12, 2023
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (1626782) 27.66% compared to head (d1582c4) 27.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6235   +/-   ##
=======================================
  Coverage   27.66%   27.66%           
=======================================
  Files        2938     2938           
  Lines      180009   180024   +15     
  Branches    19544    19551    +7     
=======================================
+ Hits        49799    49804    +5     
- Misses     129479   129487    +8     
- Partials      731      733    +2     
Impacted Files Coverage Δ
...ckages/cli/src/UserManagement/PermissionChecker.ts 73.77% <ø> (ø)
packages/core/src/NodeExecuteFunctions.ts 14.47% <0.00%> (ø)
packages/workflow/src/RoutingNode.ts 64.23% <0.00%> (-0.24%) ⬇️
packages/workflow/src/NodeErrors.ts 47.51% <33.33%> (+0.07%) ⬆️
packages/cli/src/ErrorReporting.ts 50.00% <41.66%> (-8.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy requested a review from krynble May 15, 2023 10:23
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit a4c0cc9 into master May 15, 2023
@netroy netroy deleted the reduce-sentry-noise branch May 15, 2023 13:54
MiloradFilipovic added a commit that referenced this pull request May 16, 2023
* master: (22 commits)
  fix: Remove workflow execution credential error message when instance owner (#6116)
  refactor(editor): Drop vue-typed-mixins (no-changelog) (#6257)
  feat(core): Return OAuth2 error body if available (#5794)
  fix: Add itemSize config to workflows view recycle scroller (no-changelog) (#6238)
  fix(editor): Fix close and cancel operations on useMessage (no-changelog) (#6260)
  feat(editor): Add cloud ExecutionsUsage and API blocking using licenses (#6159)
  refactor(editor): Turn showMessage mixin to composable (#6081) (#6244)
  feat(core): Add experimental proxy support to License-SDK (no-changelog) (#6253)
  feat(core): Reduce the number of events sent to Sentry (#6235)
  feat(editor): Drop support for legacy browsers that do not have native ESM support (#6239)
  refactor(editor): Add missing interface IUserListAction (no-changelog) (#6241)
  ci: Debug e2e pipeline (no-changelog) (#6240)
  Revert "refactor(editor): Turn showMessage mixin to composable" (#6243)
  feat(editor): Updating node reference pattern in expression editor (#6228)
  refactor(editor): Remove unused dependencies (no-changelog) (#6223)
  refactor(editor): Turn showMessage mixin to composable (#6081)
  feat(editor): Version Control settings update (WIP) (#6233)
  ci: Fix linting issue on master (no-changelog) (#6232)
  fix: Prevent type error messages for manual executions (no-changelog) (#6229)
  fix(Code Node): Restore help text (#6231)
  ...
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants