Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SSH Node): Replace ~ with /home/username #6269

Merged
merged 5 commits into from
May 18, 2023

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels May 18, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 58.85% and project coverage change: +0.03 🎉

Comparison is base (b7d30f3) 27.66% compared to head (414cbc1) 27.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6269      +/-   ##
==========================================
+ Coverage   27.66%   27.69%   +0.03%     
==========================================
  Files        2940     2947       +7     
  Lines      180705   180861     +156     
  Branches    19599    19634      +35     
==========================================
+ Hits        49988    50090     +102     
- Misses     129983   130026      +43     
- Partials      734      745      +11     
Impacted Files Coverage Δ
...ckages/cli/src/credentials/oauth2Credential.api.ts 0.00% <0.00%> (ø)
packages/core/src/OAuth2Helper.ts 20.00% <0.00%> (ø)
packages/nodes-base/nodes/Ssh/Ssh.node.ts 0.00% <0.00%> (ø)
packages/core/src/NodeExecuteFunctions.ts 14.43% <8.33%> (-0.04%) ⬇️
...ckages/@n8n/client-oauth2/src/ClientOAuth2Token.ts 51.61% <51.61%> (ø)
packages/@n8n/client-oauth2/src/CodeFlow.ts 65.78% <65.78%> (ø)
packages/@n8n/client-oauth2/src/ClientOAuth2.ts 75.00% <75.00%> (ø)
packages/@n8n/client-oauth2/src/utils.ts 76.00% <76.00%> (ø)
packages/@n8n/client-oauth2/src/CredentialsFlow.ts 100.00% <100.00%> (ø)
packages/@n8n/client-oauth2/src/constants.ts 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Joffcom
Joffcom previously approved these changes May 18, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 4219490 into master May 18, 2023
@michael-radency michael-radency deleted the node-519-ssh-upload-file-returns-success-but branch May 18, 2023 11:56
MiloradFilipovic added a commit that referenced this pull request May 19, 2023
* master:
  fix(Google Calendar Node): All day option fix (#6274)
  feat(Gotify Node): Add support for self signed certificates (#6053)
  docs: Remove missed beta text from Notion node (no-changelog) (#6166)
  fix(OpenAI Node): Descriptive errors (#6270)
  fix(SSH Node): Replace ~ with /home/username (#6269)
  feat(core): Replace client-oauth2 with an in-repo package (#6266)
  🚀 Release 0.229.0 (#6267)
  fix: Revert "Replace client-oauth2 with an in-repo package" (no-changelog) (#6265)
  feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming (#5613)
  feat(core): Replace client-oauth2 with an in-repo package (#6056)
  fix(editor): Fix typo and change text sizes in ExecutionUsage component (no-changelog) (#6261)
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants