-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SSH Node): Credentials test #6279
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6279 +/- ##
==========================================
- Coverage 27.69% 27.69% -0.01%
==========================================
Files 2948 2948
Lines 180869 180889 +20
Branches 19635 19636 +1
==========================================
Hits 50090 50090
- Misses 130034 130054 +20
Partials 745 745
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
✅ All Cypress E2E specs passed |
* master: fix(core): Prevent app crashes because of unhandled promises in poll and trigger nodes (#6278) fix(Postgres Node): Remove reusable connections (no-changelog) (#6259) ci(editor): Enfore stricter linting rules from `eslint-plugin-vue` (no-changelog) (#6242) fix(Strava Trigger Node): Fix issue with delete events failing to display data (#6277) feat(SSH Node): Credentials test (#6279) feat(Send Email Node): Add content-id for email attachments (#3632) feat(core): Include openssh in the base docker image (no-changelog) (#6275) # Conflicts: # packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts
Got released with |
Github issue / Community forum post (link here to close automatically):