Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Strava Trigger Node): Fix issue with delete events failing to display data #6277

Merged
merged 1 commit into from
May 19, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented May 19, 2023

Github issue / Community forum post (link here to close automatically): #2941

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5bef91e) 27.69% compared to head (6e71fe0) 27.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6277   +/-   ##
=======================================
  Coverage   27.69%   27.69%           
=======================================
  Files        2948     2948           
  Lines      180869   180869           
  Branches    19635    19635           
=======================================
  Hits        50090    50090           
  Misses     130034   130034           
  Partials      745      745           
Impacted Files Coverage Δ
...ages/nodes-base/nodes/Strava/StravaTrigger.node.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 8a8fed0 into master May 19, 2023
@Joffcom Joffcom deleted the node-175-strava-trigger-fails-if-using-resolve-on branch May 19, 2023 13:28
MiloradFilipovic added a commit that referenced this pull request May 20, 2023
* master:
  fix(core): Prevent app crashes because of unhandled promises in poll and trigger nodes (#6278)
  fix(Postgres Node): Remove reusable connections (no-changelog) (#6259)
  ci(editor): Enfore stricter linting rules from `eslint-plugin-vue` (no-changelog) (#6242)
  fix(Strava Trigger Node): Fix issue with delete events failing to display data (#6277)
  feat(SSH Node): Credentials test (#6279)
  feat(Send Email Node): Add content-id for email attachments (#3632)
  feat(core): Include openssh in the base docker image (no-changelog) (#6275)

# Conflicts:
#	packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants