Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(editor): Enfore stricter linting rules from eslint-plugin-vue (no-changelog) #6242

Merged
merged 1 commit into from
May 19, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented May 12, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 40.32% and project coverage change: -0.04 ⚠️

Comparison is base (ebb3aaf) 27.66% compared to head (44bda67) 27.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6242      +/-   ##
==========================================
- Coverage   27.66%   27.62%   -0.04%     
==========================================
  Files        2940     2940              
  Lines      180692   180660      -32     
  Branches    19595    19598       +3     
==========================================
- Hits        49984    49912      -72     
- Misses     129974   130014      +40     
  Partials      734      734              
Impacted Files Coverage Δ
packages/editor-ui/src/components/AboutModal.vue 0.00% <0.00%> (ø)
...kages/editor-ui/src/components/ActivationModal.vue 0.00% <0.00%> (ø)
packages/editor-ui/src/components/AskAiModal.vue 0.00% <0.00%> (ø)
...s/editor-ui/src/components/BreakpointsObserver.vue 35.86% <0.00%> (ø)
...s/editor-ui/src/components/ChangePasswordModal.vue 0.00% <0.00%> (ø)
...i/src/components/CodeNodeEditor/CodeNodeEditor.vue 32.85% <ø> (-0.48%) ⬇️
...ui/src/components/CommunityPackageInstallModal.vue 0.00% <0.00%> (ø)
.../components/CommunityPackageManageConfirmModal.vue 0.00% <0.00%> (ø)
...es/editor-ui/src/components/ContactPromptModal.vue 0.00% <0.00%> (ø)
...ditor-ui/src/components/CredentialsSelectModal.vue 0.00% <0.00%> (ø)
... and 40 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 12, 2023
@netroy netroy force-pushed the enforce-vue-no-unused-components branch from 5fd6b58 to eee24ce Compare May 12, 2023 15:21
@netroy netroy marked this pull request as draft May 12, 2023 15:22
@netroy netroy force-pushed the enforce-vue-no-unused-components branch from eee24ce to 8ad73cc Compare May 15, 2023 11:42
@netroy netroy force-pushed the enforce-vue-no-unused-components branch from 8ad73cc to 44bda67 Compare May 16, 2023 12:08
@netroy netroy changed the title ci(editor): Enfore vue/no-unused-components linting rule (no-changelog) ci(editor): Enfore stricter linting rules from eslint-plugin-vue (no-changelog) May 16, 2023
@netroy netroy marked this pull request as ready for review May 16, 2023 12:15
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 4b5cbe7 into master May 19, 2023
22 of 23 checks passed
@netroy netroy deleted the enforce-vue-no-unused-components branch May 19, 2023 13:31
MiloradFilipovic added a commit that referenced this pull request May 20, 2023
* master:
  fix(core): Prevent app crashes because of unhandled promises in poll and trigger nodes (#6278)
  fix(Postgres Node): Remove reusable connections (no-changelog) (#6259)
  ci(editor): Enfore stricter linting rules from `eslint-plugin-vue` (no-changelog) (#6242)
  fix(Strava Trigger Node): Fix issue with delete events failing to display data (#6277)
  feat(SSH Node): Credentials test (#6279)
  feat(Send Email Node): Add content-id for email attachments (#3632)
  feat(core): Include openssh in the base docker image (no-changelog) (#6275)

# Conflicts:
#	packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants