fix(core): Prevent app crashes because of unhandled promises in poll and trigger nodes #6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6278 +/- ##
=======================================
Coverage 27.69% 27.69%
=======================================
Files 2948 2948
Lines 180869 180869
Branches 19635 19635
=======================================
Hits 50090 50090
Misses 130034 130034
Partials 745 745
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
core
Joffcom
approved these changes
May 19, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 20, 2023
* master: fix(core): Prevent app crashes because of unhandled promises in poll and trigger nodes (#6278) fix(Postgres Node): Remove reusable connections (no-changelog) (#6259) ci(editor): Enfore stricter linting rules from `eslint-plugin-vue` (no-changelog) (#6242) fix(Strava Trigger Node): Fix issue with delete events failing to display data (#6277) feat(SSH Node): Credentials test (#6279) feat(Send Email Node): Add content-id for email attachments (#3632) feat(core): Include openssh in the base docker image (no-changelog) (#6275) # Conflicts: # packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes