-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve executions list polling performance #6355
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6355 +/- ##
==========================================
+ Coverage 28.30% 28.32% +0.02%
==========================================
Files 2982 2982
Lines 185106 185123 +17
Branches 20294 20297 +3
==========================================
+ Hits 52396 52443 +47
+ Misses 131925 131895 -30
Partials 785 785
☔ View full report in Codecov by Sentry. |
✅ All Cypress E2E specs passed |
✅ All Cypress E2E specs passed |
* master: fix(editor): Fix an issue with connections breaking during renaming (#6358) fix(core): Upgrade @n8n_io/riot-tmpl (no-changelog) (#6357) fix: Show actual execution data for production executions even if pin data exists (#6302) fix: Improve executions list polling performance (#6355) refactor: Revert 30k stars banner (no-changelog) (#6347) refactor: Add deprecation notice for basic auth and JWT auth (#6349) fix: Prevent redirect when outside of executions home (no-changelog) (#6305)
Got released with |
* refactor: move auto-refresh logic to executions list * fix: improve auto-refresh polling * fix: update executions list view to use same interval mechanism as executions sidebar * chore: fix linting issue * fix: fix executions list test * fix: fix linting issue
Description:
Because setInterval does not have the concept of async/await executions, I've implemented a custom async polling function that only runs the refresh functions 4 seconds after the previous load promise has finished executing.