fix: Improve executions list polling performance #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6355 +/- ##
==========================================
+ Coverage 28.30% 28.32% +0.02%
==========================================
Files 2982 2982
Lines 185106 185123 +17
Branches 20294 20297 +3
==========================================
+ Hits 52396 52443 +47
+ Misses 131925 131895 -30
Partials 785 785
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
n8n team
cstuncsik
previously approved these changes
Jun 1, 2023
|
✅ All Cypress E2E specs passed |
cstuncsik
approved these changes
Jun 1, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 2, 2023
* master: fix(editor): Fix an issue with connections breaking during renaming (#6358) fix(core): Upgrade @n8n_io/riot-tmpl (no-changelog) (#6357) fix: Show actual execution data for production executions even if pin data exists (#6302) fix: Improve executions list polling performance (#6355) refactor: Revert 30k stars banner (no-changelog) (#6347) refactor: Add deprecation notice for basic auth and JWT auth (#6349) fix: Prevent redirect when outside of executions home (no-changelog) (#6305)
|
Got released with |
netroy
pushed a commit
that referenced
this pull request
Jun 14, 2023
* refactor: move auto-refresh logic to executions list * fix: improve auto-refresh polling * fix: update executions list view to use same interval mechanism as executions sidebar * chore: fix linting issue * fix: fix executions list test * fix: fix linting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Because setInterval does not have the concept of async/await executions, I've implemented a custom async polling function that only runs the refresh functions 4 seconds after the previous load promise has finished executing.