Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Crypto Node): Add support for hash and hmac on binary data #6359

Merged
merged 1 commit into from
Jun 2, 2023
Merged

feat(Crypto Node): Add support for hash and hmac on binary data #6359

merged 1 commit into from
Jun 2, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 1, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023 •
edited by netroy
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit 406a405 into master Jun 2, 2023
@netroy netroy deleted the cyrpto-hash-binary-data branch June 2, 2023 09:22
MiloradFilipovic added a commit that referenced this pull request Jun 2, 2023
@MiloradFilipovic
Merge branch 'master' into sql-editor-support-expressions
b66295f 
* master:
  fix(editor): Fix hard-coded parameter names for code editors (#6372)
  ci: Add support for Node.js 18 (#5793)
  ci: Update the release process for v1 release (#6366)
  refactor: Add deprecation notice for UM disabled mode (#6367)
  feat(editor): Make WF name a link on /executions (#6354)
  ci: Revert "Set up Turborepo cache for GitHub actions runner" (#6364) (no-changelog)
  fix(editor): Add secondary icon to menu items (#6351)
  fix(editor): Pin all data regardless of pagination (#6346)
  feat(Crypto Node): Add support for hash and hmac on binary data (#6359)
  ci: Set up Turborepo cache for GitHub actions runner (no-changelog) (#6335)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInput.vue
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with n8n@0.232.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @Joffcom