fix(editor): Fix typing $ in inline expression field reloading node parameters form
#6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameters form
n8n-assistant
bot
added
n8n team
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6374 +/- ##
==========================================
- Coverage 28.32% 28.26% -0.07%
==========================================
Files 2982 2982
Lines 185204 185215 +11
Branches 20304 20303 -1
==========================================
- Hits 52465 52344 -121
- Misses 131952 132084 +132
Partials 787 787
☔ View full report in Codecov by Sentry. |
michael-radency
previously approved these changes
Jun 3, 2023
|
|
1 flaky tests on run #1092 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Workflows > should delete all the workflows |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
michael-radency
approved these changes
Jun 3, 2023
|
✅ All Cypress E2E specs passed |
krynble
pushed a commit
that referenced
this pull request
Jun 5, 2023
… parameters form (#6374) * fix(editor): Fix typing `$` in inline expression field reloading node parameters form * ⚡ Setting resource mapper empty field values to empty strings
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 5, 2023
* master: fix(editor): Handle null object on saving user settings (no-changelog) (#6341) docs: Fix trigger node link for Lonescale (#6376) ci: Improve Test-worklows messages (#6290) refactor: Upgrade to TypeScript 5.1 (no-changelog) (#6373) fix(editor): Fix typing `$` in inline expression field reloading node parameters form (#6374) 🚀 Release 0.231.0 (#6344) # Conflicts: # pnpm-lock.yaml
krynble
pushed a commit
that referenced
this pull request
Jun 6, 2023
… parameters form (#6374) * fix(editor): Fix typing `$` in inline expression field reloading node parameters form * ⚡ Setting resource mapper empty field values to empty strings
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6101 we implemented dependent parameters support for the Resource Locator Component which reloaded RLC if any of the node parameters it depends on is updated. However, this solution was causing a reload every time
watchis triggered without checking if the value actually changed.This PR fixes that and few other minor things:
ParameterInput:void-->await,ParameterInputListResourceMappercomponent optional