Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Deal with null settings #6341

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix(editor): Deal with null settings #6341

merged 1 commit into from
Jun 5, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

krynble
krynble approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

netroy
netroy reviewed May 31, 2023
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be doing this at the source of this data. so, either in sanitizeUser on the backend, or in the pinia store.
in general, views/components shouldn't be fixing data like this.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (f5ac3f4) 28.31% compared to head (bc5c01d) 28.24%.

❗ Current head bc5c01d differs from pull request most recent head 8ff221d. Consider uploading reports for the commit 8ff221d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6341      +/-   ##
==========================================
- Coverage   28.31%   28.24%   -0.07%     
==========================================
  Files        2982     2982              
  Lines      185186   185172      -14     
  Branches    20310    20303       -7     
==========================================
- Hits        52431    52300     -131     
- Misses     131968   132085     +117     
  Partials      787      787
Impacted Files Coverage Δ
packages/editor-ui/src/views/SettingsUsersView.vue 47.22% <0.00%> (-0.57%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

✅ All Cypress E2E specs passed

@krynble krynble force-pushed the noissue-fix-user-settings-empty branch from bc5c01d to 8ff221d Compare June 5, 2023 10:11
@cypress
Copy link

cypress bot commented Jun 5, 2023

1 flaky tests on run #1101 ↗︎

0 228 0 0 Flakiness 1

Details:

🌳 noissue-fix-user-settings-empty 🖥️ browsers:node18.12.0-chrome107 🤖 flipswi...
Project: n8n Commit: 8ff221d6e1
Status: Passed Duration: 07:02 💡
Started: Jun 5, 2023 10:17 AM Ended: Jun 5, 2023 10:25 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > test output schema view > should not display pagination for schema Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ All Cypress E2E specs passed

@krynble krynble merged commit 3b1a2f8 into master Jun 5, 2023
@krynble krynble deleted the noissue-fix-user-settings-empty branch June 5, 2023 11:42
MiloradFilipovic added a commit that referenced this pull request Jun 5, 2023
@MiloradFilipovic
Merge branch 'master' into sql-editor-support-expressions
048a5b3 
* master:
  fix(editor): Handle null object on saving user settings (no-changelog) (#6341)
  docs: Fix trigger node link for Lonescale (#6376)
  ci: Improve Test-worklows messages (#6290)
  refactor: Upgrade to TypeScript 5.1 (no-changelog) (#6373)
  fix(editor): Fix typing `$` in inline expression field reloading node parameters form (#6374)
  🚀 Release 0.231.0 (#6344)

# Conflicts:
#	pnpm-lock.yaml
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with n8n@0.232.0

netroy pushed a commit that referenced this pull request Jun 14, 2023
@flipswitchingmonkey @netroy
fix(editor): Handle null object on saving user settings (no-changelog) (
b9e7921 
#6341)

deal with null settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flipswitchingmonkey @janober @netroy @krynble