feat(editor): Add support for loadOptionsDependsOn to RLC
#6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Locator component
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #6101 +/- ##
=======================================
Coverage 19.19% 19.19%
=======================================
Files 2589 2589
Lines 116890 116890
Branches 18339 18339
=======================================
Hits 22439 22439
Misses 93806 93806
Partials 645 645
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
n8n team
mutdmour
reviewed
Apr 27, 2023
| dependentParametersValues() { | ||
| // Reset value if dependent parameters change | ||
| if (this.value && isResourceLocatorValue(this.value) && this.value.value !== '') { | ||
| console.log('reset value'); |
| @@ -429,6 +433,18 @@ export default mixins(debounceHelper, workflowHelpers, nodeHelpers).extend({ | |||
| this.$emit('input', { ...this.value, __regex: mode.extractValue.regex }); | |||
| } | |||
| }, | |||
| dependentParametersValues() { | |||
There was a problem hiding this comment.
I don't think we have RLC unit tests but can add some in ndv e2e tests
There was a problem hiding this comment.
I would create its own test suite
* master: fix(editor): Remove pagination from binary data output (#6093) fix(editor): Show error in RLC if credentials are not set (#6108) fix(editor): Loading state for executions tab (#6100) ci: Additionally checkout PR head for e2e tests (no-changelog) (#6105) fix(core): Skip auth for controllers/routes that don't use the `Authorized` decorator, or use `Authorized('none')` (#6106) fix(editor): Disable changing of email and pw when SAML login enabled (#6104) fix(HTTP Request Node): Always lowercase headers fix(Compression Node): Fix issue with decompression failing with uppercase extensions (#6098) fix(Mattermost Node): Fix base url trailing slash error (#6097) feat(Item Lists Node): Split out items work on objects as well as arrays
* master: fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121) fix(editor): Change wording for Variables feature available plans (no-changelog) (#6096) refactor(editor): Add skip option to activation modal (#6092) fix(HTTP Request Node): Add description for 'Specify Body' option (#6114) test(editor): Test personal settings view (#6119)
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
May 2, 2023
* master: (37 commits) fix(editor): Fix copy selection behavior (#6112) fix(core): Account for nodes with renamable content (#6109) fix(editor): Fix quote handling on dollar-sign variable completions (#6128) fix(editor): Fix cropped off completions docstrings (#6129) fix(Date & Time Node): Numbers conversions fix fix(Merge Node): Do not error if expected key is missing fix(core): Improve saml endpoints and audit events (#6107) fix: Prevent displaying an endless timer in the execution list for finished executions (#6137) fix(editor): Fix `Show details` summary (#6113) fix(editor): Fix sidebar button styling (#6138) fix(editor): Fix unique names for node duplication (#6134) fix(editor): Fix missing `Stop Listening` button (#6125) fix(editor): Fix unscrollable node settings (#6133) fix(core): Avoid using `Object.keys` on Buffer and other non-plain objects (#6131) fix(editor): Change execution list tab loader design (#6120) fix(Slack Node): Restore ability to send text in addition of blocks or attachments feat(editor): Add support for `loadOptionsDependsOn` to RLC (#6101) fix: Correctly allow sharees to test credential when opening the modal (#6111) fix(core): Fix `hasOwnProperty` on augmented objects (#6124) fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121) ...
MiloradFilipovic
added a commit
that referenced
this pull request
May 2, 2023
…rce-mapper-ui-P2 * feature/resource-mapping-component: (37 commits) fix(editor): Fix copy selection behavior (#6112) fix(core): Account for nodes with renamable content (#6109) fix(editor): Fix quote handling on dollar-sign variable completions (#6128) fix(editor): Fix cropped off completions docstrings (#6129) fix(Date & Time Node): Numbers conversions fix fix(Merge Node): Do not error if expected key is missing fix(core): Improve saml endpoints and audit events (#6107) fix: Prevent displaying an endless timer in the execution list for finished executions (#6137) fix(editor): Fix `Show details` summary (#6113) fix(editor): Fix sidebar button styling (#6138) fix(editor): Fix unique names for node duplication (#6134) fix(editor): Fix missing `Stop Listening` button (#6125) fix(editor): Fix unscrollable node settings (#6133) fix(core): Avoid using `Object.keys` on Buffer and other non-plain objects (#6131) fix(editor): Change execution list tab loader design (#6120) fix(Slack Node): Restore ability to send text in addition of blocks or attachments feat(editor): Add support for `loadOptionsDependsOn` to RLC (#6101) fix: Correctly allow sharees to test credential when opening the modal (#6111) fix(core): Fix `hasOwnProperty` on augmented objects (#6124) fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.