Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade to TypeScript 5.1 (no-changelog) #6373

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 2, 2023

@ivov ivov changed the title chore: Upgrade to TypeScript 5.1 refactor: Upgrade to TypeScript 5.1 Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (968b733) 28.33% compared to head (4d753af) 28.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6373      +/-   ##
==========================================
- Coverage   28.33%   28.24%   -0.09%     
==========================================
  Files        2982     2982              
  Lines      185187   185141      -46     
  Branches    20304    20302       -2     
==========================================
- Hits        52464    52289     -175     
- Misses     131936   132065     +129     
  Partials      787      787              

see 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivov ivov changed the title refactor: Upgrade to TypeScript 5.1 refactor: Upgrade to TypeScript 5.1 (no-changelog) Jun 5, 2023
@cypress
Copy link

cypress bot commented Jun 5, 2023

1 flaky tests on run #1095 ↗︎

0 228 0 0 Flakiness 1

Details:

🌳 upgrade-to-typescript-5.1 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/...
Project: n8n Commit: 4d753af3b3
Status: Passed Duration: 07:18 💡
Started: Jun 5, 2023 8:10 AM Ended: Jun 5, 2023 8:18 AM
Flakiness  cypress/e2e/18-user-management.cy.ts • 1 flaky test

View Output Video

Test Artifacts
User Management > should change current user password Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit e33989b into master Jun 5, 2023
@ivov ivov deleted the upgrade-to-typescript-5.1 branch June 5, 2023 08:18
MiloradFilipovic added a commit that referenced this pull request Jun 5, 2023
* master:
  fix(editor): Handle null object on saving user settings (no-changelog) (#6341)
  docs: Fix trigger node link for Lonescale (#6376)
  ci: Improve Test-worklows messages (#6290)
  refactor: Upgrade to TypeScript 5.1 (no-changelog) (#6373)
  fix(editor): Fix typing `$` in inline expression field reloading node parameters form (#6374)
  🚀 Release 0.231.0 (#6344)

# Conflicts:
#	pnpm-lock.yaml
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with n8n@0.232.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants