Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Improve Test-worklows messages #6290

Merged
merged 32 commits into from
Jun 5, 2023
Merged

ci: Improve Test-worklows messages #6290

merged 32 commits into from
Jun 5, 2023

Conversation

agobrech
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented May 22, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (4c0d4eb) 28.33% compared to head (383160a) 28.25%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6290      +/-   ##
==========================================
- Coverage   28.33%   28.25%   -0.08%     
==========================================
  Files        2982     2982              
  Lines      185215   185232      +17     
  Branches    20305    20307       +2     
==========================================
- Hits        52475    52344     -131     
- Misses     131953   132101     +148     
  Partials      787      787
Impacted Files Coverage Δ
packages/cli/src/commands/executeBatch.ts 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 22, 2023
maspio
maspio previously approved these changes Jun 2, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@agobrech agobrech requested a review from maspio June 5, 2023 09:05
@cypress
Copy link

cypress bot commented Jun 5, 2023

Passing run #1099 ↗︎

0 228 0 0 Flakiness 0

Details:

🌳 node-549-improve-test-workflow-error-messaging 🖥️ browsers:node18.12.0-chrom...
Project: n8n Commit: 383160a229
Status: Passed Duration: 07:02 💡
Started: Jun 5, 2023 9:13 AM Ended: Jun 5, 2023 9:20 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

✅ All Cypress E2E specs passed

@agobrech agobrech merged commit 3a1e96d into master Jun 5, 2023
@agobrech agobrech deleted the node-549-improve-test-workflow-error-messaging branch June 5, 2023 09:21
MiloradFilipovic added a commit that referenced this pull request Jun 5, 2023
@MiloradFilipovic
Merge branch 'master' into sql-editor-support-expressions
048a5b3 
* master:
  fix(editor): Handle null object on saving user settings (no-changelog) (#6341)
  docs: Fix trigger node link for Lonescale (#6376)
  ci: Improve Test-worklows messages (#6290)
  refactor: Upgrade to TypeScript 5.1 (no-changelog) (#6373)
  fix(editor): Fix typing `$` in inline expression field reloading node parameters form (#6374)
  🚀 Release 0.231.0 (#6344)

# Conflicts:
#	pnpm-lock.yaml
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with n8n@0.232.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agobrech @janober @maspio