Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add default author name and email to source control settings #6543

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: -0.07 ⚠️

Comparison is base (b66d151) 28.72% compared to head (3fbb0a1) 28.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6543      +/-   ##
==========================================
- Coverage   28.72%   28.65%   -0.07%     
==========================================
  Files        3000     3000              
  Lines      186293   186300       +7     
  Branches    20606    20604       -2     
==========================================
- Hits        53509    53381     -128     
- Misses     131973   132108     +135     
  Partials      811      811              
Impacted Files Coverage Δ
...ckages/editor-ui/src/stores/sourceControl.store.ts 80.34% <90.90%> (+0.34%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jun 26, 2023

1 flaky tests on run #1334 ↗︎

0 227 0 0 Flakiness 1

Details:

🌳 pay-494-overwrite-default-commit-author-by-user-data-if-available 🖥️ browser...
Project: n8n Commit: 3fbb0a18f6
Status: Passed Duration: 07:44 💡
Started: Jun 26, 2023 2:35 PM Ended: Jun 26, 2023 2:43 PM
Flakiness  cypress/e2e/18-user-management.cy.ts • 1 flaky test

View Output Video

Test Artifacts
User Management > should change current user password Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit e1a02c7 into master Jun 26, 2023
@cstuncsik cstuncsik deleted the pay-494-overwrite-default-commit-author-by-user-data-if-available branch June 26, 2023 18:17
netroy added a commit to netroy/n8n that referenced this pull request Jun 27, 2023
# [1.0.0](https://github.com/netroy/n8n/compare/n8n@0.234.0...n8n@1.0.0)
(2023-06-27)


### Bug Fixes

* **core:** Add empty credential value marker to show empty pw field
([n8n-io#6532](https://github.com/netroy/n8n/issues/6532))
([9294e2d](9294e2d))
* **core:** All migrations should run in a transaction
([n8n-io#6519](https://github.com/netroy/n8n/issues/6519))
([e152cfe](e152cfe))
* **core:** Rename to credential_stubs and variable_stubs.json
([n8n-io#6528](https://github.com/netroy/n8n/issues/6528))
([b06462f](b06462f))
* **Edit Image Node:** Fix transparent operation
([n8n-io#6513](https://github.com/netroy/n8n/issues/6513))
([4a4bcbc](4a4bcbc))
* **editor:** Add default author name and email to source control
settings ([n8n-io#6543](https://github.com/netroy/n8n/issues/6543))
([e1a02c7](e1a02c7))
* **editor:** Change default branchColor and remove label
([n8n-io#6541](https://github.com/netroy/n8n/issues/6541))
([186271e](186271e))
* **Google Drive Node:** URL parsing
([n8n-io#6527](https://github.com/netroy/n8n/issues/6527))
([d9ed0b3](d9ed0b3))
* **Google Sheets Node:** Incorrect read of 0 and false
([n8n-io#6525](https://github.com/netroy/n8n/issues/6525))
([806d134](806d134))
* **Merge Node:** Enrich input 2 fix
([n8n-io#6526](https://github.com/netroy/n8n/issues/6526))
([c82c7f1](c82c7f1))
* **Notion Node:** Version fix
([n8n-io#6531](https://github.com/netroy/n8n/issues/6531))
([38dc784](38dc784))


### Features

* Add missing input panels to some trigger nodes
([n8n-io#6518](https://github.com/netroy/n8n/issues/6518))
([fdf8a42](fdf8a42))
* **editor:** Prevent saving of workflow when canvas is loading
([n8n-io#6497](https://github.com/netroy/n8n/issues/6497))
([f89ef83](f89ef83))
* **editor:** SQL editor overhaul
([n8n-io#6282](https://github.com/netroy/n8n/issues/6282))
([beedfb6](beedfb6))
* **Google Drive Node:** Overhaul
([n8n-io#5941](https://github.com/netroy/n8n/issues/5941))
([d70a1cb](d70a1cb))
* **HTTP Request Node:** Notice about dev console
([n8n-io#6516](https://github.com/netroy/n8n/issues/6516))
([d431117](d431117))
* **Matrix Node:** Allow setting filename if the binary data has none
([n8n-io#6536](https://github.com/netroy/n8n/issues/6536))
([8b76e98](8b76e98))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Jun 28, 2023
@github-actions github-actions bot mentioned this pull request Jul 5, 2023
@janober
Copy link
Member

janober commented Jul 5, 2023

Got released with n8n@0.235.0

@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants