feat(core): Only show V1 banner to users who migrated #6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
OlegIvaniv
changed the title
netroy
approved these changes
Jul 7, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6622 +/- ##
==========================================
- Coverage 28.91% 28.85% -0.06%
==========================================
Files 3069 3069
Lines 188334 188355 +21
Branches 20889 20890 +1
==========================================
- Hits 54454 54355 -99
- Misses 133000 133120 +120
Partials 880 880 ☔ View full report in Codecov by Sentry. |
Passing run #1401 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
netroy
reviewed
Jul 10, 2023
| @@ -154,6 +154,11 @@ export class CreateUserManagement1646992772331 implements ReversibleMigration { | |||
| await queryRunner.query( | |||
| `INSERT INTO ${tablePrefix}settings (\`key\`, value, loadOnStartup) VALUES ("userManagement.isInstanceOwnerSetUp", "false", 1), ("userManagement.skipInstanceOwnerSetup", "false", 1)`, | |||
| ); | |||
|
|
|||
| await queryRunner.query(` | |||
| INSERT INTO "${tablePrefix}settings" (key, value, loadOnStartup) | |||
There was a problem hiding this comment.
@netroy 🤦 My bad, this should fix it https://github.com/n8n-io/n8n/pull/6628/files
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 11, 2023
* ADO-814-trial-banner: 👕 Fixing lint errors ✔️ Removing store import from API file ⚡ Updating banners dimensions on resize, removing leftover code refactor: Stop using `.d.ts` files for type-collection files (no-changelog) (#6634) fix(core): Fix credentials lazy-loading (no-changelog) (#6615) ci: Upgrade `tough-cookie` to address CVE-2023-26136 (no-changelog) (#6630) feat(editor): Load fixed template list as experiment (#6632) ✅ Added more banner tests feat(Slack Node): Add option to include link to workflow in Slack node (#6611) fix(editor): Extend menu item and use it as a recursive component (#6618) fix: Add postAuthenticate hook for source control preferences (no-changelog) (#6629) ✔️ Fixing failing banner tests ci: Fix v1 banner migration (no-changelog) (#6628) ✅ Added banners unit tests ✔️ Updating testing endpoints to use new store data fix(Code Node): Install python modules always in a user-writable folder (#6568) feat(core): Only show V1 banner to users who migrated (#6622) 💄 Tweaking zoom to fit position ✔️ Updating Callout component test snapshots 👕 Fixing linting errors
netroy
pushed a commit
that referenced
this pull request
Jul 12, 2023
* feat(editor): Only show V1 banner to users who migrated Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Set the v1 banner dismissed flag in settings table create migration Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to show the V1 banner only to the users that came from a pre-V1 version. To do this, we set a flag in the database in the migration script where the settings table is created.
Github issue / Community forum post (link here to close automatically):