Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix loading of scoped-community packages #6807

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

netroy
Copy link
Member

@netroy netroy commented Jul 31, 2023

Fixes #6795

@netroy netroy requested a review from Joffcom July 31, 2023 15:08
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@netroy netroy changed the title fix(code): Fix loading of scoped-community packages fix(core): Fix loading of scoped-community packages Jul 31, 2023
@MariusRumpf
Copy link

Tested it locally in my setup and fixes the issue 👍

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (37a365f) 24.61% compared to head (03088dd) 24.62%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6807   +/-   ##
=======================================
  Coverage   24.61%   24.62%           
=======================================
  Files        3122     3122           
  Lines      190546   190549    +3     
  Branches    20944    20943    -1     
=======================================
+ Hits        46910    46915    +5     
+ Misses     142708   142705    -3     
- Partials      928      929    +1     
Files Changed Coverage Δ
packages/workflow/src/utils.ts 59.30% <50.00%> (-0.23%) ⬇️
packages/cli/src/LoadNodesAndCredentials.ts 50.00% <100.00%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 31, 2023
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jul 31, 2023

Passing run #1694 ↗︎

0 221 0 0 Flakiness 0

Details:

🌳 fix-6795 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 03088ddb88
Status: Passed Duration: 07:01 💡
Started: Jul 31, 2023 3:42 PM Ended: Jul 31, 2023 3:49 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 53e58b4 into master Jul 31, 2023
18 of 19 checks passed
@netroy netroy deleted the fix-6795 branch July 31, 2023 15:55
@MariusRumpf
Copy link

Thanks a lot for the quick fix 🎉

@github-actions github-actions bot mentioned this pull request Aug 9, 2023
@janober
Copy link
Member

janober commented Aug 9, 2023

Got released with n8n@1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community package with @-prefix no longer loading
4 participants