fix(core): Resolve domains to IPv4 first #7206
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7206 +/- ##
==========================================
+ Coverage 32.65% 32.69% +0.03%
==========================================
Files 3340 3346 +6
Lines 199463 199750 +287
Branches 21849 21891 +42
==========================================
+ Hits 65139 65300 +161
- Misses 133244 133355 +111
- Partials 1080 1095 +15
☔ View full report in Codecov by Sentry. |
1 flaky test on run #2213 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
n8n-assistant
bot
added
core
|
This will solve a lot of problems we face with some VPS providers, thank you very much. |
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0) (2023-09-20) ### Bug Fixes * **core:** Make parsing of content-type and content-disposition headers more flexible ([#7217](#7217)) ([d41546b](d41546b)), closes [#7149](#7149) * **core:** Resolve domains to IPv4 first ([#7206](#7206)) ([e9ce531](e9ce531)) * **editor:** Add ssh key type selection to source control settings when regenerating key ([#7172](#7172)) ([54bf66d](54bf66d)) * **editor:** No need to add click emitting click events, VUE delegates the handler to the root element of the component ([#7182](#7182)) ([3c055e4](3c055e4)) * **editor:** Prevent duplicate creation of credential for OAuth2 ([#7163](#7163)) ([07a6417](07a6417)) * **editor:** Testing flaky resource mapper feature in e2e tests ([#7165](#7165)) ([aaf87c3](aaf87c3)) * **HTML Node:** Add pairedItem support for 'Convert to HTML Table' operation ([#7196](#7196)) ([6bc477b](6bc477b)) * **HTTP Request Node:** Decrease default timeout to 5min ([#7177](#7177)) ([321780d](321780d)) * **seven Node:** Rename sms77 to seven, fix credentials test ([#7180](#7180)) ([cf776b8](cf776b8)) * **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter alias) ([#7179](#7179)) ([d317e09](d317e09)) ### Features * **core:** Add command to trigger license refresh on workers ([#7184](#7184)) ([9f797b9](9f797b9)) * **core:** Add rsa option to ssh key generation ([#7154](#7154)) ([fdac2c8](fdac2c8)) * **Linear Node:** Add support for OAuth2 ([#7201](#7201)) ([12a3168](12a3168)) * **Microsoft Outlook Node:** Node overhaul ([#4449](#4449)) ([556a613](556a613)) * **Set Node:** Overhaul ([#6348](#6348)) ([3a47455](3a47455)) Co-authored-by: krynble <krynble@users.noreply.github.com>
* master: refactor(core): Implement soft-deletions for executions (#7092) docs(Google Sheets Node): Operations naming update (no-changelog) (#7211) fix(core): Make parsing of content-type and content-disposition headers more flexible (#7217) fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation (#7196) fix(HTTP Request Node): Decrease default timeout to 5min (#7177) feat(Linear Node): Add support for OAuth2 (#7201) refactor: Ignore large-scale revisions (no-changelog) (#7210) fix(core): Resolve domains to IPv4 first (#7206) ci: Fix tests failing on MySQL (no-changelog) (#7208) feat(Set Node): Overhaul (#6348) fix: Attempt license renewal when n8n starts (no-changelog) (#7204)
|
Please revert this change. It disgusts me to see something like this being implemented. RFC 8305 exists for a reason. If you really feel like having this anti-feature, it should be an optional config option and certainly not a forced default. |
|
Got released with |
This! You should make this a configuration so that end users can determine themselves whether they want to prioritize IPv4 over IPv6 or not. I was really excited to see that n8n finally started prioritizing IPv6 after the release of 1.0, and it's very disappointing to see that you're reverting this change so quickly. Please reconsider this! |
@DerEnderKeks When communicating with other people, language matters. Please read our code of conduct and adhere to it, to avoid getting blocked. |
|
@netroy While my remark may have been inappropriate, it wasn't personal. Either way, I'm sorry, and thanks for making it configurable! |
No description provided.