feat(core): Add rsa option to ssh key generation #7154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7154 +/- ##
==========================================
+ Coverage 32.40% 32.41% +0.01%
==========================================
Files 3278 3279 +1
Lines 198018 198031 +13
Branches 21647 21642 -5
==========================================
+ Hits 64174 64200 +26
+ Misses 132783 132771 -12
+ Partials 1061 1060 -1
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
core
krynble
reviewed
Sep 13, 2023
| @@ -118,7 +118,7 @@ export class SourceControlController { | |||
| ) { | |||
| await this.sourceControlService.setBranch(sanitizedPreferences.branchName); | |||
| } | |||
| if (sanitizedPreferences.branchColor || sanitizedPreferences.branchReadOnly !== undefined) { | |||
| if (sanitizedPreferences.branchColor ?? sanitizedPreferences.branchReadOnly !== undefined) { | |||
There was a problem hiding this comment.
Won't this assign the value of sanitizedPreferences.branchReadOnly !== undefined (which should be a boolean) to sanitizedPreferences.branchColor if the latter is nullish? Is this the intended behavior?
flipswitchingmonkey
changed the title
krynble
approved these changes
Sep 14, 2023
1 flaky test on run #2172 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should show validation errors only after blur or re-opening of NDV |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
flipswitchingmonkey
deleted the
pay-814-add-rsa-option-to-ssh-key-generation
branch
Merged
krynble
added a commit
that referenced
this pull request
Sep 20, 2023
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0) (2023-09-20) ### Bug Fixes * **core:** Make parsing of content-type and content-disposition headers more flexible ([#7217](#7217)) ([d41546b](d41546b)), closes [#7149](#7149) * **core:** Resolve domains to IPv4 first ([#7206](#7206)) ([e9ce531](e9ce531)) * **editor:** Add ssh key type selection to source control settings when regenerating key ([#7172](#7172)) ([54bf66d](54bf66d)) * **editor:** No need to add click emitting click events, VUE delegates the handler to the root element of the component ([#7182](#7182)) ([3c055e4](3c055e4)) * **editor:** Prevent duplicate creation of credential for OAuth2 ([#7163](#7163)) ([07a6417](07a6417)) * **editor:** Testing flaky resource mapper feature in e2e tests ([#7165](#7165)) ([aaf87c3](aaf87c3)) * **HTML Node:** Add pairedItem support for 'Convert to HTML Table' operation ([#7196](#7196)) ([6bc477b](6bc477b)) * **HTTP Request Node:** Decrease default timeout to 5min ([#7177](#7177)) ([321780d](321780d)) * **seven Node:** Rename sms77 to seven, fix credentials test ([#7180](#7180)) ([cf776b8](cf776b8)) * **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter alias) ([#7179](#7179)) ([d317e09](d317e09)) ### Features * **core:** Add command to trigger license refresh on workers ([#7184](#7184)) ([9f797b9](9f797b9)) * **core:** Add rsa option to ssh key generation ([#7154](#7154)) ([fdac2c8](fdac2c8)) * **Linear Node:** Add support for OAuth2 ([#7201](#7201)) ([12a3168](12a3168)) * **Microsoft Outlook Node:** Node overhaul ([#4449](#4449)) ([556a613](556a613)) * **Set Node:** Overhaul ([#6348](#6348)) ([3a47455](3a47455)) Co-authored-by: krynble <krynble@users.noreply.github.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a new field to the SourceControlPreferences as well as to the POST parameters for the
source-control/preferencesandsource-control/generate-key-pairendpoints. Both now accept an optional string parameterkeyGeneratorTypeof'ed25519' | 'rsa'Calling the
source-control/generate-key-pairendpoint with the parameter set, it will also update the stored preferences accordingly (so that in the future new keys will use the same method)By default ed25519 is being used. The default may be changed using a new environment parameter:
N8N_SOURCECONTROL_DEFAULT_SSH_KEY_TYPEwhich can bersaored25519RSA keys are generated with a length of 4096 bytes.