Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Google Drive Node): Fix issue preventing service account from downloading files #7642

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Nov 7, 2023

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/google-drive-error-cannot-read-properties-of-undefined-reading-pipe/31868/9

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 7, 2023
maspio
maspio previously approved these changes Nov 8, 2023
Copy link

cypress bot commented Nov 8, 2023

2 flaky tests on run #3765 ↗︎

0 331 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 5808215b6c
Status: Passed Duration: 03:20 💡
Started: Jan 15, 2024 2:44 PM Ended: Jan 15, 2024 2:48 PM
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video
Flakiness  29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Test Replay Screenshots Video

Review all test suite changes for PR #7642 ↗︎

Copy link
Contributor

github-actions bot commented Nov 8, 2023

✅ All Cypress E2E specs passed

…rive-file-download-fails-when-using-service-account
…rive-file-download-fails-when-using-service-account
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit cf7131d into master Jan 15, 2024
28 checks passed
@Joffcom Joffcom deleted the node-900-google-drive-file-download-fails-when-using-service-account branch January 15, 2024 15:06
netroy pushed a commit that referenced this pull request Jan 16, 2024
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
@janober
Copy link
Member

janober commented Jan 16, 2024

Got released with n8n@1.24.1

@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants