fix(editor): Fix issue with synchronization table on LDAP not loading data #8327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
RicardoE105
changed the title
mutdmour
approved these changes
Jan 15, 2024
Passing run #3756 ↗︎
Details:
Review all test suite changes for PR #8327 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
pay-1134-ldap-synchronization-table-in-ui-remains-empty-even-after
branch
netroy
pushed a commit
that referenced
this pull request
Jan 16, 2024
… data (#8327) ## Summary When we migrated to Vue3, we updated to a new component and did not provide the right props. before: https://www.loom.com/share/ce12b21fdda44176b3e949a00c582252 now: https://www.loom.com/share/354d1dcb51bd47a9910d5bfe34c7c9b8 ## Related tickets and issues https://linear.app/n8n/issue/PAY-1134/ldap-synchronization-table-in-ui-remains-empty-even-after-successful ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we migrated to Vue3, we updated to a new component and did not provide the right props.
before:
https://www.loom.com/share/ce12b21fdda44176b3e949a00c582252
now:
https://www.loom.com/share/354d1dcb51bd47a9910d5bfe34c7c9b8
Related tickets and issues
https://linear.app/n8n/issue/PAY-1134/ldap-synchronization-table-in-ui-remains-empty-even-after-successful
Review / Merge checklist
(no-changelog)otherwise. (conventions)