fix(core): Account for immediate confirmation request during test webhook creation #8329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krynble
reviewed
Jan 15, 2024
| destinationNode, | ||
| webhook: cacheableWebhook as IWebhookData, | ||
| }); | ||
| await this.registrations.register(registration); |
There was a problem hiding this comment.
We can now remove this row right? And if it fails, shouldn't we deregister as part of the catch block?
There was a problem hiding this comment.
This line ensures the static data that was updated during creation makes it into the cache.
There was a problem hiding this comment.
Got it! What about the automated de-registration if it fails?
There was a problem hiding this comment.
If registration throws, catch calls deactivateWebhooks where the last line deregisters test webhooks. That was not changed in this PR.
n8n-assistant
bot
added
core
krynble
approved these changes
Jan 15, 2024
1 flaky test on run #3767 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8329 ↗︎
|
✅ All Cypress E2E specs passed |
ivov
deleted the
account-for-immediate-confirmation-request-on-test-webhook-creation
branch
netroy
pushed a commit
that referenced
this pull request
Jan 16, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some third-party services send a confirmation request immediately on webhook creation - but by the time the confirmation request reaches the server, the test webhook not yet cached, so the confirmation request receives a 404. This PR ensures we register the test webhook before creation at the third-party service.
Tested in-memory and with Redis.
To test manually, log in to Asana using
nodeqain the vault and create a PAT, runpnpm start:tunnel, create an Asana credential, create an Asana trigger (resource is e.g. the numeric ID for a task in the URL), and create a test webhook. Creation should succeed, and user-prompted events should be received.Report: https://n8nio.slack.com/archives/C04B1GZ4T0U/p1705210902129699