fix(core): Fix telemetry for concurrency control #9845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capacity is a negative integer when there are queued items, but reportable thresholds are positive.
n8n-assistant
bot
added
core
krynble
previously approved these changes
Jun 24, 2024
4 flaky tests on run #5687 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9845 ↗︎
|
✅ All Cypress E2E specs passed |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrency limit for production executions on regular mode is currently set on cloud to
999so that we can gather data in order to set reasonable limits for cloud plans.On telemetry we had a misunderstanding on what needs to be reported - we are now reporting as follows:
capacitybecomes994, reportUser hit concurrency limit {threshold: 5}capacitybecomes989, reportUser hit concurrency limit {threshold: 10}capacitybecomes979, reportUser hit concurrency limit {threshold: 20}capacitybecomes949, reportUser hit concurrency limit {threshold: 50}capacitybecomes899, reportUser hit concurrency limit {threshold: 100}capacitybecomes799, reportUser hit concurrency limit {threshold: 200}Bear in mind this cloud-specific telemetry setup is temporary until data is gathered for a few weeks. Once cloud plan limits are set, this telemetry setup will be removed from concurrency control.
https://linear.app/n8n/issue/PAY-1627/concurrency-control-for-main-mode