Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Decouple credentials from internal hooks (no-changelog) #10162

Merged
merged 5 commits into from
Jul 25, 2024
Merged

refactor(core): Decouple credentials from internal hooks (no-changelog) #10162

merged 5 commits into from
Jul 25, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jul 23, 2024

Follow-up to: #10157

Notes:

  • On credentials created, shared, updated and deleted, we were not sending credential name to telemetry, but we were sending credential name to audit. To simplify, I removed credential name from both payloads on these four events.
  • On credentials created payload for audit, I fixed userIdsShareesRemoved to userIdsShareesAdded.
  • On credentials created, shared and deleted, we were including instanceId in the payload, but this is already added downstream for all telemetry events, so I removed instanceId from those payloads.
  • On credentials created, I expanded the payload to include with publicApi, projectId and projectType. This means that audit logs will now include those properties as well. Let's aim to minimize differences between event payloads.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 23, 2024
despairblue
despairblue requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@despairblue despairblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great description. It helped a lot understanding the changes 🙏🏾

In the code I found an omission and a bug. I think.

packages/cli/src/credentials/credentials.controller.ts Outdated Show resolved Hide resolved
packages/cli/src/PublicApi/v1/handlers/credentials/credentials.service.ts Outdated Show resolved Hide resolved
@cypress Cypress
Copy link

cypress bot commented Jul 25, 2024

Passing run #6133 ↗︎

0 387 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: f41bd8d3fd
Status: Passed Duration: 04:10 💡
Started: Jul 25, 2024 9:43 AM Ended: Jul 25, 2024 9:47 AM

Review all test suite changes for PR #10162 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 520f231 into master Jul 25, 2024
27 checks passed
@ivov ivov deleted the decouple-credentials-from-internal-hooks branch July 25, 2024 09:56
@ivov ivov mentioned this pull request Jul 29, 2024
Merged
cstuncsik pushed a commit that referenced this pull request Jul 31, 2024
@ivov @cstuncsik
refactor(core): Decouple credentials from internal hooks (no-changelo…
06a1afd 
…g) (#10162)
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

cstuncsik pushed a commit that referenced this pull request Aug 1, 2024
@ivov @cstuncsik
refactor(core): Decouple credentials from internal hooks (no-changelo…
6cbda70 
…g) (#10162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@despairblue despairblue despairblue approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @despairblue