-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Add several performance improvements when adding nodes in new canvas (no-changelog) #10170
Merged
alexgrozav
merged 7 commits into
master
from
n8n-7531-investigate-performance-improvements-when-adding-nodes
Jul 25, 2024
Merged
feat(editor): Add several performance improvements when adding nodes in new canvas (no-changelog) #10170
alexgrozav
merged 7 commits into
master
from
n8n-7531-investigate-performance-improvements-when-adding-nodes
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Jul 24, 2024
elsmr
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just found an unused function
elsmr
reviewed
Jul 24, 2024
elsmr
approved these changes
Jul 25, 2024
✅ All Cypress E2E specs passed |
Passing run #6135 ↗︎
Details:
Review all test suite changes for PR #10170 ↗︎ |
alexgrozav
deleted the
n8n-7531-investigate-performance-improvements-when-adding-nodes
branch
July 25, 2024 12:26
cstuncsik
pushed a commit
that referenced
this pull request
Jul 31, 2024
…in new canvas (no-changelog) (#10170)
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
…in new canvas (no-changelog) (#10170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Various quality of life and performance improvements. Tested with 1400+ nodes.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/N8N-7531/investigate-performance-improvements-when-adding-nodes
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)