Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add several performance improvements when adding nodes in new canvas (no-changelog) #10170

Conversation

alexgrozav
Copy link
Member

Summary

Various quality of life and performance improvements. Tested with 1400+ nodes.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7531/investigate-performance-improvements-when-adding-nodes

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Jul 24, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 24, 2024
@alexgrozav alexgrozav requested a review from elsmr July 24, 2024 12:25
Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just found an unused function

@alexgrozav alexgrozav requested a review from elsmr July 25, 2024 04:56
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 25, 2024

Passing run #6135 ↗︎

0 387 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: 4f3eb80241
Status: Passed Duration: 04:09 💡
Started: Jul 25, 2024 12:22 PM Ended: Jul 25, 2024 12:26 PM

Review all test suite changes for PR #10170 ↗︎

@alexgrozav alexgrozav merged commit 112d6b8 into master Jul 25, 2024
30 checks passed
@alexgrozav alexgrozav deleted the n8n-7531-investigate-performance-improvements-when-adding-nodes branch July 25, 2024 12:26
cstuncsik pushed a commit that referenced this pull request Jul 31, 2024
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

cstuncsik pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants