Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Remove id param from PATCH /me calls (no-changelog) #10449

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Aug 16, 2024

Summary

The PATCH /me endpoint does not take an id param.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

The PATCH /me endpoint does not take an `id` param.
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 16, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Aug 16, 2024



Test summary

401 0 0 0Flakiness 4


Run details

Project n8n
Status Passed
Commit aca0cd4
Started Aug 16, 2024 7:42 AM
Ended Aug 16, 2024 7:47 AM
Duration 04:46 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


Flakiness

17-sharing.cy.ts Flakiness
1 Sharing > credentials should work between team and personal projects
30-editor-after-route-changes.cy.ts Flakiness
1 Editor actions should work > after switching between Editor and Debug
2 Editor actions should work > after switching between Editor and Workflow history
14-mapping.cy.ts Flakiness
1 Data mapping > maps expressions from table header

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@tomi tomi merged commit 1466ff7 into master Aug 16, 2024
27 checks passed
@tomi tomi deleted the refactor-remove-unused-function-param branch August 16, 2024 09:15
MiloradFilipovic added a commit that referenced this pull request Aug 16, 2024
* master:
  fix(editor): Add workflow scopes when initializing workflow  (#10455)
  feat(editor): Improve node label readability in new canvas (no-changelog) (#10432)
  fix(editor): Fix lazy loaded component not using suspense (no-changelog) (#10454)
  fix(editor): Buffer json chunks in stream response (#10439)
  refactor(editor): Remove `id` param from PATCH /me calls (no-changelog) (#10449)
  fix(core): Fix XSS validation and separate URL validation (#10424)
  fix(Respond to Webhook Node): Fix issue preventing the chat trigger from working (#9886)
  feat(editor): Add `registerCustomAction` to new canvas (no-changelog) (#10359)
@janober
Copy link
Member

janober commented Aug 21, 2024

Got released with n8n@1.56.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants