Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix headerRow option #1760

Closed
wants to merge 1 commit into from
Closed

Conversation

lublak
Copy link
Contributor

@lublak lublak commented May 10, 2021

Returns the data in the same format whether with or without header row.
The current solution is rather poor. You write the columns as an array in a column called row.

@janober
Copy link
Member

janober commented May 12, 2021

hm, honestly not sure what to do with this as it is a breaking change. Was an easy change before it got released but now sadly not anymore.

@lublak
Copy link
Contributor Author

lublak commented May 12, 2021

@janober Unfortunately, I have no idea what the best thing to do is. But the current solution doesn't really fit.
Either it is changed quickly or you live with the dirty design. And I have to say again, it's not pretty.
Is there another solution?

@lublak
Copy link
Contributor Author

lublak commented May 17, 2021

@janober I'm working first with an internal fork, although I would like to work on the official release, just because of the updates.
But just for the clarity if my workflow throws an error and I want to look at the csv import. (I work a lot with csv files without header, so it is very important for me to have it in a readable form).

If it is not wanted here because it is a breaking change, you can close it.

@janober
Copy link
Member

janober commented May 19, 2021

Thanks a lot. I thought now about it some more.

For now, I will leave it as it is. For two reasons:

  1. To avoid a breaking change
  2. It works now already similar to how Google Sheet node returns RAW data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants