-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SeaTable node #1976
Add SeaTable node #1976
Conversation
Sorry for the delay. We try to review the PR asap. |
Just refreshed on top of master as the PR got a bit stale @janober |
Thanks! Very sorry. We will try to review now really asap. |
Btw. had a very fast look. It looks like it would have to be changed to work consistently as recent similar nodes like for example Baserow or NocoDB. You can find the code here: It allows users to set data in two different ways. One by using the incoming data directly and the other by setting it field by field. Hope that makes sense. |
Ah and additionally do we now have a node linter thanks to @ivov : That already displays a lot of common issues of nodes. If all of that is done we should be able to merge the node very fast as there would not be much to do on our side anymore. Thanks! |
Can it be described on high level that a mapping of the input data is possible (on entity level) - instead of having a mapping node in front @janober ?
I'll take a look and then looking forward to integrate it. Much appreciated @janober |
Yes, that is correct. But important to mention that both are possible and the user can select which way of setting the data he/she prefers. If you run the Baserow or NocoDB node in n8n it will become directly clear. |
Please find this PR updated for nodelinter changes. As I had some problem getting it to run, please take a look this looks good so far @janober |
51692ec
to
0ba664e
Compare
Please find this in the updated PR incl. loading table- and column-names from SeaTable server (load-options methods) @janober
I addressed those common issues, some of them look like false-positives to me and then I worked with the annotations. Additionally I was able to crash node.js by running nodelinter. |
Just updated from beta-3 to beta-4 which prevents crashing nodelinter and also the change to async credentials getting reminded to improve the nodes credentials handling which has been done as well. rtr. |
Node for SeaTable, initial credentials, trigger- and standard-node. Contribution-by: SeaTable GmbH <https://seatable.io> Signed-off-by: Tom Klingenberg <tkl@seatable.io>
Refreshed against current head, please review @janober. |
Thanks a lot. Got merged with #2240 |
Got released with n8n@0.141.0 |
Node for SeaTable, initial credentials, trigger- and standard-node.
Contribution-by: SeaTable GmbH https://seatable.io
Signed-off-by: Tom Klingenberg tkl@seatable.io