Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implements Magento Auth API Test #3026

Closed
wants to merge 2 commits into from
Closed

✨ Implements Magento Auth API Test #3026

wants to merge 2 commits into from

Conversation

paolo-rechia
Copy link
Contributor

Implements Magento Api Test

Implementation Strategy:

  • Calls endpoint rest/default/V1/directory/countries with provided access token.
  • Assumption: access token has rights to this endpoint.

Tested with Local Magento Docker Environment.
Success case:
image

Failed case:
image

@Joffcom Joffcom added node/improvement New feature or request community Authored by a community member labels Mar 22, 2022
@Joffcom
Copy link
Member

Joffcom commented Apr 4, 2022

Hey @paolo-rechia,

I was just testing this one and it looks like Magento defaults to providing anonymous access to the endpoint being used so in my environment of a clean Magento install if I put in the URL and any value for the access token it returns as a successful connection.

image

What I have done is changed the URI to /modules which is a protected resource, I have also tweaked the formatting a bit. Like the other PR I was unable to update this one so I have opened #3086, I will mark this one as closed.

Let me know if you have any questions and thanks for your time on the PR 🙌🏻

@Joffcom Joffcom closed this Apr 4, 2022
@janober
Copy link
Member

janober commented Apr 8, 2022

Thanks a lot for your contribution @paolo-rechia . Got merged with #3086

@janober janober added the Upcoming Release Will be part of the upcoming release label Apr 8, 2022
@janober
Copy link
Member

janober commented Apr 11, 2022

Got released with n8n@0.172.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants