Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with Reddit node not getting all posts #3597

Merged
merged 2 commits into from
Jun 26, 2022
Merged

Fixes issue with Reddit node not getting all posts #3597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7734bb3
Fixed issue with Reddit node not getting all posts
Joffcom Jun 24, 2022
aaa6bbc
Fixed remaining issues with required options
Joffcom Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/nodes-base/nodes/MonicaCrm/descriptions/ConversationMessageDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ export const conversationMessageFields: INodeProperties[] = [
name: 'written_by_me',
description: 'Author of the message',
type: 'options',
required: true,
default: true,
options: [
{
Expand Down
3 changes: 0 additions & 3 deletions packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,6 @@ export class Pipedrive implements INodeType {
name: 'org_id',
type: 'number',
default: 0,
required: true,
displayOptions: {
show: {
'/associateWith': [
Expand Down Expand Up @@ -1731,7 +1730,6 @@ export class Pipedrive implements INodeType {
numberPrecision: 2,
},
default: 0.00,
required: true,
description: 'Price at which to add or update this product in a deal',
},
{
Expand All @@ -1742,7 +1740,6 @@ export class Pipedrive implements INodeType {
typeOptions: {
minValue: 1,
},
required: true,
description: 'How many items of this product to add/update in a deal',
},
{
Expand Down
1 change: 0 additions & 1 deletion packages/nodes-base/nodes/Reddit/PostDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ export const postFields: INodeProperties[] = [
displayName: 'Category',
name: 'category',
type: 'options',
required: true,
default: 'top',
description: 'Category of the posts to retrieve',
options: [
Expand Down
1 change: 0 additions & 1 deletion packages/nodes-base/nodes/Splunk/descriptions/UserDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ export const userFields: INodeProperties[] = [
name: 'roles',
type: 'multiOptions',
description: 'Comma-separated list of roles to assign to the user. Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
required: true,
default: [],
typeOptions: {
loadOptionsMethod: 'getRoles',
Expand Down
1 change: 0 additions & 1 deletion packages/nodes-base/nodes/Wait/Wait.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,6 @@ export class Wait implements INodeType {
name: 'binaryPropertyName',
type: 'string',
default: 'data',
required: true,
displayOptions: {
show: {
binaryData: [
Expand Down