Added 'Source Excludes' and 'Source Includes' options on Elasticsearch node's 'document: getAll' operation #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
community
|
Hey @miguel-mconf, Thanks for the contribution 🙌🏻 I have made a small change to the credentials to support injection and testing, I was unable to push to your master branch so I have created a new PR that uses your changes here #3660 What I will do is get this one closed and we can continue on the other PR, If you have any questions let me know. |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the Elasticsearch node.
The 'Source Excludes' and 'Source Includes' options weren't present in the 'document: getAll' operation, being present only in the 'document: get' operation.
So I've simply copied both options from the 'document: get' operation to the 'document: getAll' operation, without changing anything, and it worked flawlessly.
In summary, this adds the source filtering functionality to the 'document: getAll' operation from the Elasticsearch node, without implementing any additional logic.