Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix horizontal overflow for dialogs #6830

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix: Fix horizontal overflow for dialogs #6830

merged 1 commit into from
Aug 2, 2023

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Aug 1, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 1, 2023
@mutdmour mutdmour changed the title fix: horizontal overflow for dialogs fix: Fix horizontal overflow for dialogs Aug 2, 2023
MiloradFilipovic
MiloradFilipovic approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@cypress
Copy link

cypress bot commented Aug 2, 2023

Passing run #1741 ↗︎

0 221 0 0 Flakiness 0

Details:

🌳 n8n-6799 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project: n8n Commit: 0ba5dc365a
Status: Passed Duration: 07:50 💡
Started: Aug 2, 2023 10:23 AM Ended: Aug 2, 2023 10:31 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit 41d8a18 into master Aug 2, 2023
17 of 18 checks passed
@mutdmour mutdmour deleted the n8n-6799 branch August 2, 2023 12:45
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Merged
@janober
Copy link
Member

janober commented Aug 9, 2023

Got released with n8n@1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

Assignees

@mutdmour mutdmour

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @MiloradFilipovic