fix(core): Setup websocket keep-live messages

[netroy]

fixes #6757

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

• If fixing bug, added test to cover scenario.
• If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

• Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (0913e0d) 25.06% compared to head (b09029d) 25.05%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6866      +/-   ##
==========================================
- Coverage   25.06%   25.05%   -0.01%     
==========================================
  Files        3149     3149              
  Lines      191932   191949      +17     
  Branches    21112    21109       -3     
==========================================
- Hits        48105    48102       -3     
- Misses     142846   142866      +20     
  Partials      981      981              

Files Changed	Coverage Δ
packages/cli/src/push/index.ts	24.56% <0.00%> (ø)
packages/cli/src/push/websocket.push.ts	7.69% <0.00%> (-14.53%)	⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[luizeof]

hello @netroy do you plan to publish to docker hub?

[netroy]

@luizeof just pushed a custom image with the tag ws-keepalive.

[netroy]

@luizeof did you test the docker image?

[netroy]

@luizeof Can you let us know if this change fixes the issue for you? if not, we should close this PR.

[luizeof]

hello @netroy .. sorry for the long wait

this docker image does not load, it gives an error with redis (but redis is correct)

[netroy]

The branch was likely missing this fix.
Just rebased the branch, and built a new image.
Can you please try again 🙏🏽.

[luizeof]

@netroy .. it works !!! cloudflare didn't drop the connection.

Thanks !!!!

[krynble]

LGTM

[cypress]

2 flaky tests on run #2015 ↗︎

0

232

0

0

2

Details:

🌳 ws-keepalive 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n	Commit: bae9b3d18e
Status: Passed	Duration: 09:23 💡
Started: Aug 28, 2023 7:38 AM	Ended: Aug 28, 2023 7:47 AM

  16-webhook-node.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Webhook Trigger node > should listen for a POST request		Output Screenshots Video

  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items		Output Screenshots Video

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[github-actions]

✅ All Cypress E2E specs passed

[krynble]

QQ about this one: I do not see anything in my browser's console related to the ping events. I'm guessing this is due to be an internal protocol mechanism that is not broadcasted externally, am I correct in this assumption? I debugged the code and I could see the ping being called correctly, so I assume it's all well.

[netroy]

QQ about this one: I do not see anything in my browser's console related to the ping events. I'm guessing this is due to be an internal protocol mechanism that is not broadcasted externally, am I correct in this assumption?

Yeah, browser devtools do not show non-data frames like ping-pong, binary data, or connection close frame. The only way to test this is on the server-side, like you did.

[janober]

Got released with n8n@1.5.1