feat(core): Add MFA #4767
Merged
feat(core): Add MFA #4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
reviewed
Feb 14, 2023
netroy
reviewed
Feb 14, 2023
netroy
reviewed
Feb 14, 2023
netroy
reviewed
Feb 14, 2023
netroy
reviewed
Feb 14, 2023
netroy
reviewed
Feb 14, 2023
netroy
reviewed
Feb 14, 2023
netroy
reviewed
Feb 14, 2023
packages/cli/src/databases/migrations/sqlite/1669730543736-addMfaColumns.ts
Outdated
Show resolved
Hide resolved
Have you tried with a fresh database, creating the tables from scratch? If I use an existing database (that was already migrated with I'm using MySQL version 8.0.32 here, if that helps. |
mutdmour
approved these changes
Aug 23, 2023
|
|
Passing run #1979 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
krynble
previously approved these changes
Aug 23, 2023
|
|
OlegIvaniv
previously approved these changes
Aug 23, 2023
mutdmour
previously approved these changes
Aug 23, 2023
|
|
1 similar comment
|
|
RicardoE105
dismissed stale reviews from mutdmour, OlegIvaniv, and krynble
via
b7818fe
krynble
approved these changes
Aug 23, 2023
|
|
|
✅ All Cypress E2E specs passed |
netroy
reviewed
Aug 24, 2023
|
|
||
| export class AddMfaColumns1690000000030 implements ReversibleMigration { | ||
| async up({ queryRunner, tablePrefix }: MigrationContext) { | ||
| await queryRunner.addColumns(`${tablePrefix}user`, [ |
There was a problem hiding this comment.
adding removing columns like causes data-loss because of a typeorm issue. Fix here.
Merged
netroy
added a commit
that referenced
this pull request
Aug 31, 2023
# [1.5.0](https://github.com/n8n-io/n8n/compare/n8n@1.4.0...n8n@1.5.0) (2023-08-31) ### Bug Fixes * **Agile CRM Node:** Fix issue with company address not working ([#6997](#6997)) ([2f81652](2f81652)) * **Code Node:** Switch over to vm2 fork ([#7018](#7018)) ([dfe0fa6](dfe0fa6)) * **core:** Invalid NODES_INCLUDE should not crash the app ([#7038](#7038)) ([04e3178](04e3178)), closes [#6683](#6683) * **core:** Setup websocket keep-live messages ([#6866](#6866)) ([8bdb07d](8bdb07d)), closes [#6757](#6757) * **core:** Throw `NodeSSLError` only for nodes that allow ignoring SSL issues ([#6928](#6928)) ([a01c3fb](a01c3fb)) * **Date & Time Node:** Dont parse date if it's not set (null or undefined) ([#7050](#7050)) ([d72f79f](d72f79f)) * **editor:** Fix sending of Ask AI tracking events ([#7002](#7002)) ([fb05afa](fb05afa)) * **Microsoft Excel 365 Node:** Support for more extensions in workbook rlc ([#7020](#7020)) ([d6e1cf2](d6e1cf2)) * **MongoDB Node:** Stringify response ObjectIDs ([#6990](#6990)) ([9ca990b](9ca990b)) * **MongoDB Node:** Upgrade mongodb package to address CVE-2021-32050 ([#7054](#7054)) ([d3f6356](d3f6356)) * **Postgres Node:** Empty return data fix for Postgres and MySQL ([#7016](#7016)) ([176ccd6](176ccd6)) * **Webhook Node:** Fix URL params for webhooks ([#6986](#6986)) ([596b569](596b569)) ### Features * **core:** External Secrets storage for credentials ([#6477](#6477)) ([ed927d3](ed927d3)) * **core:** Add MFA ([#4767](#4767)) ([2b7ba6f](2b7ba6f)) * **core:** Add filtering, selection and pagination to users ([#6994](#6994)) ([b716241](b716241)) * **editor:** Debug executions in the editor ([#6834](#6834)) ([c833078](c833078)) * **RSS Read Node:** Add support for self signed certificates ([#7039](#7039)) ([3b9f0fe](3b9f0fe)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/ADO-947/sync-branch-with-master-and-fix-fe-e2e-tets
https://community.n8n.io/t/2fa-n8n-cloud/4580