Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Postgres Node): Empty return data fix for Postgres and MySQL #7016

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Aug 25, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.01% ⚠️

Comparison is base (07d3633) 32.13% compared to head (6edd715) 32.12%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7016      +/-   ##
==========================================
- Coverage   32.13%   32.12%   -0.01%     
==========================================
  Files        3183     3183              
  Lines      195611   195641      +30     
  Branches    21339    21350      +11     
==========================================
+ Hits        62850    62851       +1     
- Misses     131772   131800      +28     
- Partials      989      990       +1     
Files Changed Coverage Δ
packages/nodes-base/nodes/MySql/MySql.node.ts 0.00% <ø> (ø)
...-base/nodes/MySql/v2/actions/versionDescription.ts 0.00% <ø> (ø)
...ackages/nodes-base/nodes/Postgres/Postgres.node.ts 0.00% <ø> (ø)
...se/nodes/Postgres/v2/actions/versionDescription.ts 0.00% <ø> (ø)
...ages/nodes-base/nodes/Postgres/v2/helpers/utils.ts 58.63% <11.11%> (-6.25%) ⬇️
...ackages/nodes-base/nodes/MySql/v2/helpers/utils.ts 67.03% <87.50%> (+0.76%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Aug 25, 2023

Passing run #2011 ↗︎

0 232 0 0 Flakiness 0

Details:

🌳 node-634-postgresmysql-nodes-dont-output-success-true-when-using 🖥️ browsers...
Project: n8n Commit: 6edd7155ed
Status: Passed Duration: 08:30 💡
Started: Aug 25, 2023 3:28 PM Ended: Aug 25, 2023 3:36 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 176ccd6 into master Aug 25, 2023
52 checks passed
@michael-radency michael-radency deleted the node-634-postgresmysql-nodes-dont-output-success-true-when-using branch August 25, 2023 15:38
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
netroy added a commit that referenced this pull request Aug 31, 2023
# [1.5.0](https://github.com/n8n-io/n8n/compare/n8n@1.4.0...n8n@1.5.0)
(2023-08-31)


### Bug Fixes

* **Agile CRM Node:** Fix issue with company address not working
([#6997](#6997))
([2f81652](2f81652))
* **Code Node:** Switch over to vm2 fork
([#7018](#7018))
([dfe0fa6](dfe0fa6))
* **core:** Invalid NODES_INCLUDE should not crash the app
([#7038](#7038))
([04e3178](04e3178)),
closes [#6683](#6683)
* **core:** Setup websocket keep-live messages
([#6866](#6866))
([8bdb07d](8bdb07d)),
closes [#6757](#6757)
* **core:** Throw `NodeSSLError` only for nodes that allow ignoring SSL
issues ([#6928](#6928))
([a01c3fb](a01c3fb))
* **Date & Time Node:** Dont parse date if it's not set (null or
undefined) ([#7050](#7050))
([d72f79f](d72f79f))
* **editor:** Fix sending of Ask AI tracking events
([#7002](#7002))
([fb05afa](fb05afa))
* **Microsoft Excel 365 Node:** Support for more extensions in workbook
rlc ([#7020](#7020))
([d6e1cf2](d6e1cf2))
* **MongoDB Node:** Stringify response ObjectIDs
([#6990](#6990))
([9ca990b](9ca990b))
* **MongoDB Node:** Upgrade mongodb package to address CVE-2021-32050
([#7054](#7054))
([d3f6356](d3f6356))
* **Postgres Node:** Empty return data fix for Postgres and MySQL
([#7016](#7016))
([176ccd6](176ccd6))
* **Webhook Node:** Fix URL params for webhooks
([#6986](#6986))
([596b569](596b569))


### Features

* **core:** External Secrets storage for credentials
([#6477](#6477))
([ed927d3](ed927d3))
* **core:** Add MFA ([#4767](#4767))
([2b7ba6f](2b7ba6f))
* **core:** Add filtering, selection and pagination to users
([#6994](#6994))
([b716241](b716241))
* **editor:** Debug executions in the editor
([#6834](#6834))
([c833078](c833078))
* **RSS Read Node:** Add support for self signed certificates
([#7039](#7039))
([3b9f0fe](3b9f0fe))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Aug 31, 2023

Got released with n8n@1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants