fix(Convert to/from binary data Node): Rename 'Move Binary Data' to 'Convert to/from binary data' #7318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
elsmr
changed the title
n8n-assistant
bot
added
community
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7318 +/- ##
==========================================
- Coverage 33.21% 33.20% -0.01%
==========================================
Files 3366 3366
Lines 201011 201011
Branches 22050 22046 -4
==========================================
- Hits 66762 66755 -7
- Misses 133139 133146 +7
Partials 1110 1110
☔ View full report in Codecov by Sentry. |
michael-radency
previously approved these changes
Oct 3, 2023
1 flaky test on run #2357 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Output
Screenshots
Video
|
|
Review all test suite changes for PR #7318 ↗︎
michael-radency
approved these changes
Oct 4, 2023
|
✅ All Cypress E2E specs passed |
Merged
krynble
added a commit
that referenced
this pull request
Oct 5, 2023
# [1.10.0](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.10.0) (2023-10-05) ### Bug Fixes * **Convert to/from binary data Node:** Rename 'Move Binary Data' to 'Convert to/from binary data' ([#7318](#7318)) ([5e6c1d4](5e6c1d4)) * **core:** Account for itemless case on restoring binary data ID ([#7305](#7305)) ([1691223](1691223)) * **core:** Fix pruning of non-finished executions ([#7333](#7333)) ([1b4848a](1b4848a)) * **editor:** Disable email confirmation banner for trialing users ([#7340](#7340)) ([6d3d178](6d3d178)) * **editor:** Display value of selected matching column in RMC ([#7298](#7298)) ([3aac22b](3aac22b)) * **editor:** Fix canvas endpoint snapping when dragging connection ([#7346](#7346)) ([b59b908](b59b908)) * **editor:** Fix disappearing NDV header in code nodes ([#7290](#7290)) ([7ebf8f3](7ebf8f3)) * **editor:** Fix RLC not loading when an expression can't resolve ([#7295](#7295)) ([ddc26c2](ddc26c2)) * **editor:** Separate cloud endpoint calls ([#7312](#7312)) ([04dfcd7](04dfcd7)) * **Jira Software Node:** Get all users in dropdown/RLC ([#7322](#7322)) ([3704760](3704760)), closes [#2670](#2670) * **Notion Node:** Rename Notion API Key to Internal Integration Token ([#7176](#7176)) ([ec2aa38](ec2aa38)) * **Postgres Node:** Node requires comma-separated string even when using a single parameter through an expression ([#7300](#7300)) ([763d451](763d451)) * **Set Node:** Do not stringify null and undefined ([#7313](#7313)) ([f0a6687](f0a6687)) * **Typeform Trigger Node:** Change output format for TypeForm trigger to object instead of array ([#7315](#7315)) ([b3fc00e](b3fc00e)) ### Features * **core:** Add "Sent by n8n" attribution ([#7183](#7183)) ([8f9fe62](8f9fe62)) * **core:** Add support for building LLM applications ([#7235](#7235)) ([00a4b8b](00a4b8b)), closes [#7246](#7246) [#7137](#7137) * Workflow History pruning and prune time settings ([#7343](#7343)) ([0adc533](0adc533)) Co-authored-by: krynble <krynble@users.noreply.github.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):