Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression #7300

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression #7300

merged 1 commit into from
Sep 29, 2023

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Sep 29, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ec2aa38) 33.03% compared to head (552bd27) 33.03%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7300   +/-   ##
=======================================
  Coverage   33.03%   33.03%           
=======================================
  Files        3360     3360           
  Lines      200366   200368    +2     
  Branches    21994    21997    +3     
=======================================
+ Hits        66196    66201    +5     
+ Misses     133060   133057    -3     
  Partials     1110     1110
Files Coverage Δ
...gres/v2/actions/database/executeQuery.operation.ts 69.44% <33.33%> (-4.09%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 29, 2023

1 flaky test on run #2320 ↗︎

0 242 3 0 Flakiness 1

Details:

🌳 node-810-postgres-node-requires-comma-separated-string-even-when 🖥️ browsers...
Project: n8n Commit: 552bd2719f
Status: Passed Duration: 08:31 💡
Started: Sep 29, 2023 9:37 AM Ended: Sep 29, 2023 9:45 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should retrieve remote options when non-required params throw errors Output Screenshots Video

Review all test suite changes for PR #7300 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 763d451 into master Sep 29, 2023
18 checks passed
@michael-radency michael-radency deleted the node-810-postgres-node-requires-comma-separated-string-even-when branch September 29, 2023 10:27
MiloradFilipovic added a commit that referenced this pull request Oct 2, 2023
@MiloradFilipovic
Merge branch 'master' into ADO-1126-ndv-header-scroll-fix
0c2aec9 
* master:
  fix(editor): Separate cloud endpoint calls (#7312)
  fix(core): Account for itemless case on restoring binary data ID (#7305)
  feat(editor): Workflow history [WIP]- create workflow history list component (no-changelog) (#7186)
  feat(core): Add plan name to telemetry (no-changelog) (#7296)
  ci: Fix typescript incremental builds (no-changelog) (#7275)
  fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression (#7300)
  fix(Notion Node): Rename Notion API Key to Internal Integration Token (#7176)
  🚀 Release 1.9.0 (#7288)
  ci: Refactor DB tests (no-changelog) (#7292)
  fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors (#7293)
  fix(Respond to Webhook Node): JSON output from expression fix (#7294)
  feat(core): Add secrets provider reload and refactor (#7277)
netroy pushed a commit that referenced this pull request Oct 4, 2023
@michael-radency @netroy
fix(Postgres Node): Node requires comma-separated string even when us…
43534ab 
…ing a single parameter through an expression (#7300)

Github issue / Community forum post (link here to close automatically):
@github-actions github-actions bot mentioned this pull request Oct 4, 2023
Merged
netroy added a commit that referenced this pull request Oct 4, 2023
@github-actions @netroy
🚀 Release 1.9.1 (#7349)
e0ed561 
## [1.9.1](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.9.1)
(2023-10-04)


### Bug Fixes

* **core:** Account for itemless case on restoring binary data ID
([#7305](#7305))
([c479d86](c479d86))
* **core:** Fix pruning of non-finished executions
([#7333](#7333))
([d8309a1](d8309a1))
* **editor:** Disable email confirmation banner for trialing users
([#7340](#7340))
([3815327](3815327))
* **editor:** Display value of selected matching column in RMC
([#7298](#7298))
([9fbd22e](9fbd22e))
* **editor:** Fix canvas endpoint snapping when dragging connection
([#7346](#7346))
([b4681e7](b4681e7))
* **editor:** Fix RLC not loading when an expression can't resolve
([#7295](#7295))
([116a6df](116a6df))
* **editor:** Separate cloud endpoint calls
([#7312](#7312))
([54610b0](54610b0))
* **Jira Software Node:** Get all users in dropdown/RLC
([#7322](#7322))
([7abf13b](7abf13b)),
closes [#2670](#2670)
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176](#7176))
([e606ded](e606ded))
* **Postgres Node:** Node requires comma-separated string even when
using a single parameter through an expression
([#7300](#7300))
([43534ab](43534ab))
* **Set Node:** Do not stringify null and undefined
([#7313](#7313))
([326abaa](326abaa))
* **Typeform Trigger Node:** Change output format for TypeForm trigger
to object instead of array
([#7315](#7315))
([b1fc981](b1fc981))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 4, 2023

Got released with n8n@1.9.1

@github-actions github-actions bot mentioned this pull request Oct 4, 2023
Merged
krynble added a commit that referenced this pull request Oct 5, 2023
@github-actions @krynble
🚀 Release 1.10.0 (#7350)
aa1bf95 
# [1.10.0](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.10.0)
(2023-10-05)


### Bug Fixes

* **Convert to/from binary data Node:** Rename 'Move Binary Data' to
'Convert to/from binary data'
([#7318](#7318))
([5e6c1d4](5e6c1d4))
* **core:** Account for itemless case on restoring binary data ID
([#7305](#7305))
([1691223](1691223))
* **core:** Fix pruning of non-finished executions
([#7333](#7333))
([1b4848a](1b4848a))
* **editor:** Disable email confirmation banner for trialing users
([#7340](#7340))
([6d3d178](6d3d178))
* **editor:** Display value of selected matching column in RMC
([#7298](#7298))
([3aac22b](3aac22b))
* **editor:** Fix canvas endpoint snapping when dragging connection
([#7346](#7346))
([b59b908](b59b908))
* **editor:** Fix disappearing NDV header in code nodes
([#7290](#7290))
([7ebf8f3](7ebf8f3))
* **editor:** Fix RLC not loading when an expression can't resolve
([#7295](#7295))
([ddc26c2](ddc26c2))
* **editor:** Separate cloud endpoint calls
([#7312](#7312))
([04dfcd7](04dfcd7))
* **Jira Software Node:** Get all users in dropdown/RLC
([#7322](#7322))
([3704760](3704760)),
closes [#2670](#2670)
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176](#7176))
([ec2aa38](ec2aa38))
* **Postgres Node:** Node requires comma-separated string even when
using a single parameter through an expression
([#7300](#7300))
([763d451](763d451))
* **Set Node:** Do not stringify null and undefined
([#7313](#7313))
([f0a6687](f0a6687))
* **Typeform Trigger Node:** Change output format for TypeForm trigger
to object instead of array
([#7315](#7315))
([b3fc00e](b3fc00e))


### Features

* **core:** Add "Sent by n8n" attribution
([#7183](#7183))
([8f9fe62](8f9fe62))
* **core:** Add support for building LLM applications
([#7235](#7235))
([00a4b8b](00a4b8b)),
closes [#7246](#7246)
[#7137](#7137)
* Workflow History pruning and prune time settings
([#7343](#7343))
([0adc533](0adc533))

Co-authored-by: krynble <krynble@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-radency @janober @maspio