Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Jira Software Node): Get all users in dropdown/RLC #7322

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Oct 2, 2023

Github issue / Community forum post (link here to close automatically):

fixes #2670

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (e7a90c7) 33.30% compared to head (7bf5777) 33.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7322      +/-   ##
==========================================
- Coverage   33.30%   33.29%   -0.01%     
==========================================
  Files        3376     3376              
  Lines      205691   205685       -6     
  Branches    22140    22135       -5     
==========================================
- Hits        68498    68490       -8     
- Misses     136080   136082       +2     
  Partials     1113     1113              
Files Coverage Δ
packages/nodes-base/nodes/Jira/Jira.node.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/Jira/GenericFunctions.ts 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cypress
Copy link

cypress bot commented Oct 3, 2023

1 flaky test on run #2347 ↗︎

0 242 3 0 Flakiness 1

Details:

🌳 node-42-jira-pagination 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 7bf5777de9
Status: Passed Duration: 08:38 💡
Started: Oct 3, 2023 6:47 AM Ended: Oct 3, 2023 6:56 AM
Flakiness  cypress/e2e/12-canvas.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should rename node using keyboard shortcut Output Screenshots Video

Review all test suite changes for PR #7322 ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 3704760 into master Oct 3, 2023
54 of 55 checks passed
@elsmr elsmr deleted the node-42-jira-pagination branch October 3, 2023 08:04
netroy pushed a commit that referenced this pull request Oct 4, 2023
Github issue / Community forum post (link here to close automatically):

fixes #2670

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
@github-actions github-actions bot mentioned this pull request Oct 4, 2023
netroy added a commit that referenced this pull request Oct 4, 2023
## [1.9.1](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.9.1)
(2023-10-04)


### Bug Fixes

* **core:** Account for itemless case on restoring binary data ID
([#7305](#7305))
([c479d86](c479d86))
* **core:** Fix pruning of non-finished executions
([#7333](#7333))
([d8309a1](d8309a1))
* **editor:** Disable email confirmation banner for trialing users
([#7340](#7340))
([3815327](3815327))
* **editor:** Display value of selected matching column in RMC
([#7298](#7298))
([9fbd22e](9fbd22e))
* **editor:** Fix canvas endpoint snapping when dragging connection
([#7346](#7346))
([b4681e7](b4681e7))
* **editor:** Fix RLC not loading when an expression can't resolve
([#7295](#7295))
([116a6df](116a6df))
* **editor:** Separate cloud endpoint calls
([#7312](#7312))
([54610b0](54610b0))
* **Jira Software Node:** Get all users in dropdown/RLC
([#7322](#7322))
([7abf13b](7abf13b)),
closes [#2670](#2670)
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176](#7176))
([e606ded](e606ded))
* **Postgres Node:** Node requires comma-separated string even when
using a single parameter through an expression
([#7300](#7300))
([43534ab](43534ab))
* **Set Node:** Do not stringify null and undefined
([#7313](#7313))
([326abaa](326abaa))
* **Typeform Trigger Node:** Change output format for TypeForm trigger
to object instead of array
([#7315](#7315))
([b1fc981](b1fc981))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 4, 2023

Got released with n8n@1.9.1

@github-actions github-actions bot mentioned this pull request Oct 4, 2023
krynble added a commit that referenced this pull request Oct 5, 2023
# [1.10.0](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.10.0)
(2023-10-05)


### Bug Fixes

* **Convert to/from binary data Node:** Rename 'Move Binary Data' to
'Convert to/from binary data'
([#7318](#7318))
([5e6c1d4](5e6c1d4))
* **core:** Account for itemless case on restoring binary data ID
([#7305](#7305))
([1691223](1691223))
* **core:** Fix pruning of non-finished executions
([#7333](#7333))
([1b4848a](1b4848a))
* **editor:** Disable email confirmation banner for trialing users
([#7340](#7340))
([6d3d178](6d3d178))
* **editor:** Display value of selected matching column in RMC
([#7298](#7298))
([3aac22b](3aac22b))
* **editor:** Fix canvas endpoint snapping when dragging connection
([#7346](#7346))
([b59b908](b59b908))
* **editor:** Fix disappearing NDV header in code nodes
([#7290](#7290))
([7ebf8f3](7ebf8f3))
* **editor:** Fix RLC not loading when an expression can't resolve
([#7295](#7295))
([ddc26c2](ddc26c2))
* **editor:** Separate cloud endpoint calls
([#7312](#7312))
([04dfcd7](04dfcd7))
* **Jira Software Node:** Get all users in dropdown/RLC
([#7322](#7322))
([3704760](3704760)),
closes [#2670](#2670)
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176](#7176))
([ec2aa38](ec2aa38))
* **Postgres Node:** Node requires comma-separated string even when
using a single parameter through an expression
([#7300](#7300))
([763d451](763d451))
* **Set Node:** Do not stringify null and undefined
([#7313](#7313))
([f0a6687](f0a6687))
* **Typeform Trigger Node:** Change output format for TypeForm trigger
to object instead of array
([#7315](#7315))
([b3fc00e](b3fc00e))


### Features

* **core:** Add "Sent by n8n" attribution
([#7183](#7183))
([8f9fe62](8f9fe62))
* **core:** Add support for building LLM applications
([#7235](#7235))
([00a4b8b](00a4b8b)),
closes [#7246](#7246)
[#7137](#7137)
* Workflow History pruning and prune time settings
([#7343](#7343))
([0adc533](0adc533))

Co-authored-by: krynble <krynble@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jira Node cropping user's selection list to max of 50 results
3 participants