fix(Google Sheets Node): Append or update runs forever when without column headers #7463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…google-sheets-append-or-update-runs-forever-when-column
michael-radency
added
n8n team
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7463 +/- ##
==========================================
- Coverage 33.50% 33.49% -0.01%
==========================================
Files 3392 3393 +1
Lines 207345 207385 +40
Branches 22375 22378 +3
==========================================
- Hits 69468 69467 -1
- Misses 136749 136790 +41
Partials 1128 1128
☔ View full report in Codecov by Sentry. |
maspio
approved these changes
Oct 19, 2023
Passing run #2515 ↗︎
Details:
Review all test suite changes for PR #7463 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-738-google-sheets-append-or-update-runs-forever-when-column
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Oct 19, 2023
* master: refactor(core): Make executions pruning settings configurable (#7468) feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) (#7406) feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) (#7405) fix(core): Do not return `inviteAcceptUrl` in response if email was sent (#7465) fix(Google Sheets Node): Append or update runs forever when without column headers (#7463)
netroy
pushed a commit
that referenced
this pull request
Oct 23, 2023
…olumn headers (#7463) Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: Marcus <marcus@n8n.io>
Merged
netroy
added a commit
that referenced
this pull request
Oct 23, 2023
## [1.12.1](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.12.1) (2023-10-23) ### Bug Fixes * **core:** Do not return `inviteAcceptUrl` in response if email was sent ([#7465](#7465)) ([4a1f4da](4a1f4da)) * **core:** Handle gzip and deflate compressed request payloads ([#7461](#7461)) ([75981fb](75981fb)) * **core:** Reduce logging overhead for levels that do not output ([#7479](#7479)) ([4a1641d](4a1641d)) * **Customer.io Node:** Fix api endpoint when using EU region ([#7485](#7485)) ([ea1b503](ea1b503)), closes [#7484](#7484) * **editor:** Allow importing the same workflow multiple times ([#7458](#7458)) ([15e1737](15e1737)), closes [#7457](#7457) * **editor:** Fix canvas selection breaking after interacting with node actions ([#7466](#7466)) ([d84c367](d84c367)) * **editor:** Fix connections disappearing after reactivating canvas and renaming a node ([#7483](#7483)) ([368e3ee](368e3ee)) * **Google Sheets Node:** Append or update runs forever when without column headers ([#7463](#7463)) ([0d52490](0d52490)) * **MySQL Node:** Resolve expressions in v1 ([#7464](#7464)) ([70a10a9](70a10a9)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Merged
netroy
added a commit
that referenced
this pull request
Oct 25, 2023
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0) (2023-10-25) ### Bug Fixes * **core:** Do not return `inviteAcceptUrl` in response if email was sent ([#7465](#7465)) ([55c6a1b](55c6a1b)) * **core:** Ensure nodes post-processors run in the correct order ([#7500](#7500)) ([6f45298](6f45298)) * **core:** Fix `frontend.settings` external hook execution ([#7496](#7496)) ([774fe20](774fe20)) * **core:** Handle gzip and deflate compressed request payloads ([#7461](#7461)) ([83762e0](83762e0)) * **core:** Reduce logging overhead for levels that do not output ([#7479](#7479)) ([76c0481](76c0481)) * **Customer.io Node:** Fix api endpoint when using EU region ([#7485](#7485)) ([519680c](519680c)) * **editor:** Allow importing the same workflow multiple times ([#7458](#7458)) ([3c0a166](3c0a166)) * **editor:** Fix canvas selection breaking after interacting with node actions ([#7466](#7466)) ([bc47365](bc47365)) * **editor:** Fix connections disappearing after reactivating canvas and renaming a node ([#7483](#7483)) ([450e0cc](450e0cc)) * **Google Sheets Node:** Append or update runs forever when without column headers ([#7463](#7463)) ([ab6a9bb](ab6a9bb)) * **Microsoft SQL Node:** Prevent SQL injection ([#7467](#7467)) ([a739245](a739245)) * **MQTT Trigger Node:** Fix node causing a start up hang when active ([#7498](#7498)) ([baecb93](baecb93)) * **MySQL Node:** Resolve expressions in v1 ([#7464](#7464)) ([5c46bb0](5c46bb0)) * **Redis Node:** Fix adding sets data types ([#7444](#7444)) ([4e66023](4e66023)) * **Spreadsheet File Node:** Fix include empty cells not working with v2 ([#7505](#7505)) ([05e6f2a](05e6f2a)) ### Features * **core:** Add support for oauth based service accounts with UM SMTP ([#7311](#7311)) ([647372b](647372b)) * **editor:** Add PH tracking to event ([#7511](#7511)) ([c47d27d](c47d27d)) * **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node ([#7113](#7113)) ([ac814a9](ac814a9)) * **Ghost Node:** Add support for lexical format ([#7488](#7488)) ([7b1973c](7b1973c)) * **RSS Feed Trigger Node:** Add RSS feed trigger node ([#7386](#7386)) ([689360e](689360e)) Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):