Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Ensure nodes post-processors run in the correct order #7500

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(core): Ensure nodes post-processors run in the correct order #7500

merged 1 commit into from
Oct 25, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Oct 23, 2023

Fixes #7497

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@netroy netroy requested a review from Joffcom October 23, 2023 15:03
Joffcom
Joffcom previously approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it works :)

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (05e6f2a) 33.61% compared to head (1596195) 33.60%.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7500      +/-   ##
==========================================
- Coverage   33.61%   33.60%   -0.01%     
==========================================
  Files        3399     3399              
  Lines      207468   207477       +9     
  Branches    22419    22416       -3     
==========================================
- Hits        69737    69733       -4     
- Misses     136598   136612      +14     
+ Partials     1133     1132       -1
Files Coverage Δ
...blicApi/v1/handlers/workflows/workflows.handler.ts 85.08% <100.00%> (-0.26%) ⬇️
packages/cli/src/commands/BaseCommand.ts 32.14% <100.00%> (ø)
...kages/cli/src/workflows/workflows.controller.ee.ts 77.41% <100.00%> (+0.37%) ⬆️
packages/cli/src/workflows/workflows.controller.ts 68.06% <100.00%> (-0.53%) ⬇️
packages/cli/src/workflows/workflows.services.ts 59.01% <100.00%> (+1.87%) ⬆️
packages/cli/src/WorkflowRunnerProcess.ts 0.00% <0.00%> (ø)
...lows/workflowHistory/workflowHistory.service.ee.ts 93.54% <75.00%> (-2.89%) ⬇️
packages/cli/src/services/frontend.service.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/views/NodeView.vue 17.49% <0.00%> (-0.02%) ⬇️
packages/cli/src/Server.ts 0.00% <0.00%> (ø)
... and 1 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 23, 2023 •
edited

Passing run #2573 ↗︎

0 258 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 15961950eb
Status: Passed Duration: 09:49 💡
Started: Oct 25, 2023 11:47 AM Ended: Oct 25, 2023 11:57 AM

Review all test suite changes for PR #7500 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 23, 2023
@netroy netroy requested a review from Joffcom October 23, 2023 16:54
Joffcom
Joffcom previously approved these changes Oct 24, 2023
View reviewed changes
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy netroy marked this pull request as draft October 24, 2023 09:13
@netroy netroy marked this pull request as ready for review October 25, 2023 10:37
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 6f45298 into master Oct 25, 2023
56 checks passed
@netroy netroy deleted the fix-postProcessorOrder branch October 25, 2023 11:59
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
netroy added a commit that referenced this pull request Oct 25, 2023
@github-actions @netroy
🚀 Release 1.13.0 (#7512)
2987587 
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0)
(2023-10-25)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](#7465))
([55c6a1b](55c6a1b))
* **core:** Ensure nodes post-processors run in the correct order
([#7500](#7500))
([6f45298](6f45298))
* **core:** Fix `frontend.settings` external hook execution
([#7496](#7496))
([774fe20](774fe20))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([83762e0](83762e0))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([76c0481](76c0481))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](#7485))
([519680c](519680c))
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([3c0a166](3c0a166))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([bc47365](bc47365))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([450e0cc](450e0cc))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](#7463))
([ab6a9bb](ab6a9bb))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467](#7467))
([a739245](a739245))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498](#7498))
([baecb93](baecb93))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([5c46bb0](5c46bb0))
* **Redis Node:** Fix adding sets data types
([#7444](#7444))
([4e66023](4e66023))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505](#7505))
([05e6f2a](05e6f2a))


### Features

* **core:** Add support for oauth based service accounts with UM SMTP
([#7311](#7311))
([647372b](647372b))
* **editor:** Add PH tracking to event
([#7511](#7511))
([c47d27d](c47d27d))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113](#7113))
([ac814a9](ac814a9))
* **Ghost Node:** Add support for lexical format
([#7488](#7488))
([7b1973c](7b1973c))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386](#7386))
([689360e](689360e))

Co-authored-by: netroy <netroy@users.noreply.github.com>
MiloradFilipovic added a commit that referenced this pull request Oct 25, 2023
@MiloradFilipovic
Merge branch 'master' into debug-canvas-selection
57c8f2a 
* master: (30 commits)
  🚀 Release 1.14.0 (#7514)
  ci: Fix oclif manifest generation
  feat(Switch Node): Add support for infinite Switch outputs (#7499)
  🚀 Release 1.13.0 (#7512)
  fix(core): Ensure nodes post-processors run in the correct order (#7500)
  feat(editor): Add PH tracking to event (#7511)
  fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) (#7508)
  refactor(core): Make executions pruning more resilient (#7480)
  fix(Spreadsheet File Node): Fix include empty cells not working with v2 (#7505)
  fix(core): Create instance settings directory recursively (no-changelog) (#7506)
  fix(Microsoft SQL Node): Prevent SQL injection (#7467)
  refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory (#7482)
  fix(core): Always derive `instanceId` from the encryption key (no-changlog) (#7501)
  fix(MQTT Trigger Node): Fix node causing a start up hang when active (#7498)
  feat: Collect usage metrics on license renewal (no-changelog) (#7486)
  fix(core): Fix `frontend.settings` external hook execution (#7496)
  fix(Redis Node): Fix adding sets data types (#7444)
  fix: Save new version of the workflow instead of the previous (no-changelog) (#7428)
  refactor(core): Abstract away InstanceSettings and `encryptionKey` into injectable services (no-changelog) (#7471)
  fix(Customer.io Node): Fix api endpoint when using EU region (#7485)
  ...
@janober
Copy link
Member

janober commented Oct 25, 2023

Got released with n8n@1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 1.11.x - Could not get parameter "pollTimes"!"
3 participants
@netroy @janober @Joffcom