Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix canvas selection breaking after interacting with node actions #7466

Merged
merged 3 commits into from
Oct 20, 2023
Merged

fix(editor): Fix canvas selection breaking after interacting with node actions #7466

merged 3 commits into from
Oct 20, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Oct 19, 2023 •
edited
Loading

Sometimes canvas selection stops working after users interact with node action buttons (for example if node is moved by dragging one of the buttons)
NOTE: Ticket number in the branch name is wrong, this fixes ADO-1226

@MiloradFilipovic MiloradFilipovic self-assigned this Oct 19, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/views/NodeView.vue:

  • Avoided adding code here. Only refactored to make it smaller.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c7c8048) 33.54% compared to head (ac633d9) 33.49%.
Report is 1 commits behind head on master.

❗ Current head ac633d9 differs from pull request most recent head 241c582. Consider uploading reports for the commit 241c582 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7466      +/-   ##
==========================================
- Coverage   33.54%   33.49%   -0.05%     
==========================================
  Files        3393     3393              
  Lines      207403   207379      -24     
  Branches    22405    22379      -26     
==========================================
- Hits        69566    69466     -100     
- Misses     136716   136785      +69     
- Partials     1121     1128       +7
Files Coverage Δ
packages/editor-ui/src/views/NodeView.vue 17.53% <100.00%> (+0.01%) ⬆️
packages/editor-ui/src/stores/canvas.store.ts 14.79% <0.00%> (-0.15%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OlegIvaniv
OlegIvaniv reviewed Oct 19, 2023
View reviewed changes
cypress/e2e/12-canvas-actions.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/12-canvas-actions.cy.ts Outdated Show resolved Hide resolved
@MiloradFilipovic
👌 Optimizing test code
c6faa2b
@MiloradFilipovic
Merge branch 'master' into ado-1225-fix-selection-after-drag
241c582 
* master:
  refactor(core): Make executions pruning settings configurable (#7468)
  feat(editor): Workflow history [WIP] - Remove pinned data from workflow history version preview (no-changelog) (#7406)
  feat(editor): Workflow history [WIP] - Add cloned workflow link to success toast message (no-changelog) (#7405)
  fix(core): Do not return `inviteAcceptUrl` in response if email was sent (#7465)
  fix(Google Sheets Node): Append or update runs forever when without column headers (#7463)
@cypress
Copy link

cypress bot commented Oct 20, 2023

Passing run #2523 ↗︎

0 257 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project: n8n Commit: 241c582d7e
Status: Passed Duration: 08:07 💡
Started: Oct 20, 2023 6:59 AM Ended: Oct 20, 2023 7:07 AM

Review all test suite changes for PR #7466 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit bc47365 into master Oct 20, 2023
57 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ado-1225-fix-selection-after-drag branch October 20, 2023 07:26
netroy pushed a commit that referenced this pull request Oct 23, 2023
@MiloradFilipovic @netroy
fix(editor): Fix canvas selection breaking after interacting with nod…
90ce8de 
…e actions (#7466)

Sometimes canvas selection stops working after users interact with node
action buttons (for example if node is moved by dragging one of the
buttons)
NOTE: Ticket number in the branch name is wrong, this fixes ADO-1226
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
netroy added a commit that referenced this pull request Oct 23, 2023
@github-actions @netroy
🚀 Release 1.11.2 (#7492)
a16bc1d 
## [1.11.2](https://github.com/n8n-io/n8n/compare/n8n@1.11.1...n8n@1.11.2)
(2023-10-23)


### Bug Fixes

* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([f43ff71](f43ff71))
* **core:** Prevent false stalled jobs in queue mode from displaying as
errored ([#7435](#7435))
([465a952](465a952))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([010aa57](010aa57))
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([33e3df8](33e3df8)),
closes [#7457](#7457)
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([90ce8de](90ce8de))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([b0bd0d8](b0bd0d8))
* **editor:** Open only one tab with plans page
([#7377](#7377))
([d14e9cb](d14e9cb))
* **Ldap Node:** Fix issue with connections not closing correctly
([#7432](#7432))
([60ca02e](60ca02e))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([2b18909](2b18909))
* **TheHive 5 Node:** Observable encoding in alert > create fix
([#7450](#7450))
([b9547ad](b9547ad))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 23, 2023

Got released with n8n@1.11.2

netroy pushed a commit that referenced this pull request Oct 23, 2023
@MiloradFilipovic @netroy
fix(editor): Fix canvas selection breaking after interacting with nod…
d84c367 
…e actions (#7466)

Sometimes canvas selection stops working after users interact with node
action buttons (for example if node is moved by dragging one of the
buttons)
NOTE: Ticket number in the branch name is wrong, this fixes ADO-1226
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
netroy added a commit that referenced this pull request Oct 23, 2023
@github-actions @netroy
🚀 Release 1.12.1 (#7493)
2e79f64 
## [1.12.1](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.12.1)
(2023-10-23)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](#7465))
([4a1f4da](4a1f4da))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([75981fb](75981fb))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([4a1641d](4a1641d))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](#7485))
([ea1b503](ea1b503)),
closes [#7484](#7484)
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([15e1737](15e1737)),
closes [#7457](#7457)
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([d84c367](d84c367))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([368e3ee](368e3ee))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](#7463))
([0d52490](0d52490))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([70a10a9](70a10a9))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
netroy added a commit that referenced this pull request Oct 25, 2023
@github-actions @netroy
🚀 Release 1.13.0 (#7512)
2987587 
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0)
(2023-10-25)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](#7465))
([55c6a1b](55c6a1b))
* **core:** Ensure nodes post-processors run in the correct order
([#7500](#7500))
([6f45298](6f45298))
* **core:** Fix `frontend.settings` external hook execution
([#7496](#7496))
([774fe20](774fe20))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([83762e0](83762e0))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([76c0481](76c0481))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](#7485))
([519680c](519680c))
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([3c0a166](3c0a166))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([bc47365](bc47365))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([450e0cc](450e0cc))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](#7463))
([ab6a9bb](ab6a9bb))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467](#7467))
([a739245](a739245))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498](#7498))
([baecb93](baecb93))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([5c46bb0](5c46bb0))
* **Redis Node:** Fix adding sets data types
([#7444](#7444))
([4e66023](4e66023))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505](#7505))
([05e6f2a](05e6f2a))


### Features

* **core:** Add support for oauth based service accounts with UM SMTP
([#7311](#7311))
([647372b](647372b))
* **editor:** Add PH tracking to event
([#7511](#7511))
([c47d27d](c47d27d))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113](#7113))
([ac814a9](ac814a9))
* **Ghost Node:** Add support for lexical format
([#7488](#7488))
([7b1973c](7b1973c))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386](#7386))
([689360e](689360e))

Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloradFilipovic @janober @OlegIvaniv