fix(Google Sheets Node): Check for null before destructuring
#7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
maspio
approved these changes
Nov 16, 2023
|
|
3 flaky tests on run #2918 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Canvas Node Manipulation and Navigation > should add nodes and check execution success |
Screenshots
Video
|
|
6-code-node.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Code node > Code editor > should execute the placeholder successfully in both modes |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Screenshots
Video
|
|
Review all test suite changes for PR #7729 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
pushed a commit
that referenced
this pull request
Nov 17, 2023
Merged
netroy
added a commit
that referenced
this pull request
Nov 17, 2023
## [1.17.1](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.17.1) (2023-11-17) ### Bug Fixes * **core:** Correct permissions for getstatus ([#7724](#7724)) ([422af2e](422af2e)) * **editor:** Make sure LineController is registered with chart.js ([#7730](#7730)) ([7d4f0cc](7d4f0cc)) * **editor:** Show v1 banner dismiss button if owner ([#7722](#7722)) ([1f6ee4d](1f6ee4d)) * **GitHub Node:** Fix issue preventing file edits on branches ([#7734](#7734)) ([340fe29](340fe29)) * **Google Sheets Node:** Check for `null` before de-structuring ([#7729](#7729)) ([2507c31](2507c31)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Merged
ivov
added a commit
that referenced
this pull request
Nov 22, 2023
# [1.18.0](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.18.0) (2023-11-22) ### Bug Fixes * **core:** Account for non-ASCII chars in filename on binary data download ([#7742](#7742)) ([b4ebb1a](b4ebb1a)) * **core:** Correct permissions for getstatus ([#7724](#7724)) ([f96c1d2](f96c1d2)) * **core:** Ensure failed executions are saved in queue mode ([#7744](#7744)) ([b7c5c74](b7c5c74)) * **core:** Guard against node not found on cancelling test webhook ([#7750](#7750)) ([6be453b](6be453b)) * **editor:** Handle permission edge cases (empty scopes) ([#7723](#7723)) ([e2ffd39](e2ffd39)) * **editor:** Make sure LineController is registered with chart.js ([#7730](#7730)) ([ebee1a5](ebee1a5)) * **editor:** Move workerview entry into settings menu ([#7761](#7761)) ([366cd67](366cd67)) * **editor:** Only show push to git menu item to owners ([#7766](#7766)) ([0d3d33d](0d3d33d)) * **editor:** Show v1 banner dismiss button if owner ([#7722](#7722)) ([44d3b3e](44d3b3e)) * **editor:** Use project diagram icon for worker view ([#7764](#7764)) ([ff0b651](ff0b651)) * **editor:** Validate user info before submiting ([#7608](#7608)) ([2064f7f](2064f7f)) * **GitHub Node:** Fix issue preventing file edits on branches ([#7734](#7734)) ([ce002a6](ce002a6)) * **Google Sheets Node:** Check for `null` before destructuring ([#7729](#7729)) ([5d4a52d](5d4a52d)) * **Item Lists Node:** Don't check same type in remove duplicates operation ([#7678](#7678)) ([4f30764](4f30764)) * **JotForm Trigger Node:** Fix iteration on form loader ([#7751](#7751)) ([82f3202](82f3202)) ### Features * Add Creator hub link to Templates page ([#7721](#7721)) ([4dbae0e](4dbae0e)) * **core:** Coordinate manual workflow activation and deactivation in multi-main scenario ([#7643](#7643)) ([4c40825](4c40825)) * **editor:** Add node context menu ([#7620](#7620)) ([8d12c1a](8d12c1a)) * **editor:** Node IO filter ([#7503](#7503)) ([1881765](1881765)) Co-authored-by: ivov <ivov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://n8nio.sentry.io/issues/4613453684