Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Move workerview entry into settings menu #7761

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

As the worker view is not an essential function, it is being moved from the main side bar to the settings side bar for the time being.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 21, 2023
Copy link

cypress bot commented Nov 21, 2023

3 flaky tests on run #2967 ↗︎

0 278 5 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 flipswitchingmonkey 🗃️ e2e/*
Project: n8n Commit: d5a7669743
Status: Passed Duration: 06:18 💡
Started: Nov 21, 2023 10:19 AM Ended: Nov 21, 2023 10:25 AM
Flakiness  12-canvas-actions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Actions > should execute node Screenshots Video
Flakiness  28-resource-mapper.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Mapper > should correctly delete single field Screenshots Video
Flakiness  28-debug.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Debug > should be able to debug executions Screenshots Video

Review all test suite changes for PR #7761 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@flipswitchingmonkey flipswitchingmonkey merged commit 366cd67 into master Nov 21, 2023
58 of 59 checks passed
@flipswitchingmonkey flipswitchingmonkey deleted the pay-1032-move-worker-view-into-settings branch November 21, 2023 10:29
MiloradFilipovic added a commit that referenced this pull request Nov 22, 2023
* master: (89 commits)
  feat(core): Make postgres pool-size configurable (no-changelog) (#7772)
  refactor(core): Include execution progress in save settings (no-changelog) (#7769)
  refactor: Upgrade to TypeScript 5.3 (no-changelog) (#7768)
  fix(editor): Only show push to git menu item to owners (#7766)
  fix(editor): Use project diagram icon for worker view (#7764)
  fix(Item Lists Node): Don't check same type in remove duplicates operation (#7678)
  fix(editor): Move workerview entry into settings menu (#7761)
  fix(core): Ensure failed executions are saved in queue mode (#7744)
  docs: Update docs links for data transformation functions and ifEmpty (#7758)
  feat(editor): Add node context menu (#7620)
  feat: Add Creator hub link to Templates page (#7721)
  fix: Include cypress TypeScript types in /cypress folder (no-changelog) (#7746)
  refactor(core): Stop reporting to Sentry `NodeApiError` outside 500 range (no-changelog) (#7753)
  fix(core): Guard against node not found on cancelling test webhook (#7750)
  fix(JotForm Trigger Node): Fix iteration on form loader (#7751)
  refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) (#7752)
  feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643)
  ci: Fix "Release: Create Pull Request" workflow
  fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) (#7738)
  fix(editor): Remove `n8nHooksNext` flag (no-changelog) (#7733)
  ...
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
ivov added a commit that referenced this pull request Nov 22, 2023
#
[1.18.0](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.18.0)
(2023-11-22)


### Bug Fixes

* **core:** Account for non-ASCII chars in filename on binary data
download ([#7742](#7742))
([b4ebb1a](b4ebb1a))
* **core:** Correct permissions for getstatus
([#7724](#7724))
([f96c1d2](f96c1d2))
* **core:** Ensure failed executions are saved in queue mode
([#7744](#7744))
([b7c5c74](b7c5c74))
* **core:** Guard against node not found on cancelling test webhook
([#7750](#7750))
([6be453b](6be453b))
* **editor:** Handle permission edge cases (empty scopes)
([#7723](#7723))
([e2ffd39](e2ffd39))
* **editor:** Make sure LineController is registered with chart.js
([#7730](#7730))
([ebee1a5](ebee1a5))
* **editor:** Move workerview entry into settings menu
([#7761](#7761))
([366cd67](366cd67))
* **editor:** Only show push to git menu item to owners
([#7766](#7766))
([0d3d33d](0d3d33d))
* **editor:** Show v1 banner dismiss button if owner
([#7722](#7722))
([44d3b3e](44d3b3e))
* **editor:** Use project diagram icon for worker view
([#7764](#7764))
([ff0b651](ff0b651))
* **editor:** Validate user info before submiting
([#7608](#7608))
([2064f7f](2064f7f))
* **GitHub Node:** Fix issue preventing file edits on branches
([#7734](#7734))
([ce002a6](ce002a6))
* **Google Sheets Node:** Check for `null` before destructuring
([#7729](#7729))
([5d4a52d](5d4a52d))
* **Item Lists Node:** Don't check same type in remove duplicates
operation ([#7678](#7678))
([4f30764](4f30764))
* **JotForm Trigger Node:** Fix iteration on form loader
([#7751](#7751))
([82f3202](82f3202))


### Features

* Add Creator hub link to Templates page
([#7721](#7721))
([4dbae0e](4dbae0e))
* **core:** Coordinate manual workflow activation and deactivation in
multi-main scenario ([#7643](#7643))
([4c40825](4c40825))
* **editor:** Add node context menu
([#7620](#7620))
([8d12c1a](8d12c1a))
* **editor:** Node IO filter
([#7503](#7503))
([1881765](1881765))

Co-authored-by: ivov <ivov@users.noreply.github.com>
MiloradFilipovic added a commit that referenced this pull request Nov 22, 2023
* master:
  🚀 Release 1.18.0 (#7780)
  fix(core): Pass correct node reference to NodeExecuteFunctions.getLoadOptionsFunctions (no-changelog) (#7779)
  docs: Add workflow template contribution to the contributing guide (#7777)
  fix(editor): Validate user info before submiting (#7608)
  feat(core): Make postgres pool-size configurable (no-changelog) (#7772)
  refactor(core): Include execution progress in save settings (no-changelog) (#7769)
  refactor: Upgrade to TypeScript 5.3 (no-changelog) (#7768)
  fix(editor): Only show push to git menu item to owners (#7766)
  fix(editor): Use project diagram icon for worker view (#7764)
  fix(Item Lists Node): Don't check same type in remove duplicates operation (#7678)
  fix(editor): Move workerview entry into settings menu (#7761)
  fix(core): Ensure failed executions are saved in queue mode (#7744)
  docs: Update docs links for data transformation functions and ifEmpty (#7758)
  feat(editor): Add node context menu (#7620)
@janober
Copy link
Member

janober commented Nov 22, 2023

Got released with n8n@1.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants