Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Validate user info before submiting #7608

Merged
merged 11 commits into from
Nov 22, 2023
Merged

fix(editor): Validate user info before submiting #7608

merged 11 commits into from
Nov 22, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

Validate first and last names before saving them to database. This should prevent security issue with un-sanitized data that ends up in emails.

@MiloradFilipovic
fix: Prevent code injection by validating name fields
45132d9
@MiloradFilipovic
⚡ Validate first name and last name on setup
90ae20f
@MiloradFilipovic
⚡ Adding back-end validation
7c093f1
@MiloradFilipovic
✅ Added SetupView tests
9912ff7
@MiloradFilipovic
Merge branch 'master' into ADO-1322-fix-name-field-code-injection
8d42119 
* master:
  feat(editor): Fix some UTM tags (no-changelog) (#7583)
  feat(editor): Improve performance by importing routes dynamically and add route guards (no-changelog) (#7567)
  fix(editor): Zoom in/out on canvas the same amount on scroll/gesture (#7602)
@MiloradFilipovic MiloradFilipovic self-assigned this Nov 3, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 3, 2023
mutdmour
mutdmour previously approved these changes Nov 8, 2023
View reviewed changes
@cypress Cypress
Copy link

cypress bot commented Nov 8, 2023 •
edited

1 flaky test on run #2980 ↗︎

0 282 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project: n8n Commit: 4f2d6ced60
Status: Passed Duration: 05:52 💡
Started: Nov 22, 2023 11:06 AM Ended: Nov 22, 2023 11:12 AM
Flakiness  cypress/e2e/28-resource-mapper.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Mapper > should correctly delete single field Screenshots Video

Review all test suite changes for PR #7608 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

✅ All Cypress E2E specs passed

@MiloradFilipovic
Merge branch 'master' into ADO-1322-fix-name-field-code-injection
72d7e52 
* master: (24 commits)
  fix(Crypto Node): Fix issue with value not appearing for Sign action (#7619)
  feat(NocoDB Node): Add new data apis and workspace support (#7329)
  fix(Facebook Lead Ads Trigger Node): Fix issue with missing scope for business management  (#7616)
  refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648)
  fix(editor): Fix workflow history prune time limit (getting hours instead of days) (#7644)
  fix(core): Comply with custom default for workflow saving settings (#7634)
  feat(core): Initial support for two-way communication over websockets (#7570)
  ci: Conditionally re-enable coverage for frontend packages (no-changelog) (#7641)
  ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550)
  fix(core): Make password-reset urls valid only for single-use (#7622)
  fix: Error handling on forgot password page (no-changelog) (#7633)
  ci: Improve CI performance (no-changelog) (#7637)
  fix(core): Ensure pruning starts only after migrations have completed (#7626)
  feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566)
  fix(editor): Fix local storage flags defaulting to undefined string (#7603)
  fix(editor): Reset canvas zoom before workspace reset in node view (#7625)
  fix(editor): More dark-mode fixes (no-changelog) (#7624)
  fix(core): Fix accessor error when running partial execution (#7618)
  fix(editor): Fix issue that frontend breaks with unkown nodes (#7596)
  fix(core): Ensure `init` before checking leader or follower in multi-main scenario (#7621)
  ...
@netroy netroy dismissed mutdmour’s stale review November 15, 2023 11:11

We should not be validating firstName/lastName on the backend like this. we should instead escape the name in the email templates.

MiloradFilipovic and others added 4 commits November 22, 2023 08:51
@MiloradFilipovic
Merge branch 'master' into ADO-1322-fix-name-field-code-injection
8b35797 
* master: (89 commits)
  feat(core): Make postgres pool-size configurable (no-changelog) (#7772)
  refactor(core): Include execution progress in save settings (no-changelog) (#7769)
  refactor: Upgrade to TypeScript 5.3 (no-changelog) (#7768)
  fix(editor): Only show push to git menu item to owners (#7766)
  fix(editor): Use project diagram icon for worker view (#7764)
  fix(Item Lists Node): Don't check same type in remove duplicates operation (#7678)
  fix(editor): Move workerview entry into settings menu (#7761)
  fix(core): Ensure failed executions are saved in queue mode (#7744)
  docs: Update docs links for data transformation functions and ifEmpty (#7758)
  feat(editor): Add node context menu (#7620)
  feat: Add Creator hub link to Templates page (#7721)
  fix: Include cypress TypeScript types in /cypress folder (no-changelog) (#7746)
  refactor(core): Stop reporting to Sentry `NodeApiError` outside 500 range (no-changelog) (#7753)
  fix(core): Guard against node not found on cancelling test webhook (#7750)
  fix(JotForm Trigger Node): Fix iteration on form loader (#7751)
  refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) (#7752)
  feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643)
  ci: Fix "Release: Create Pull Request" workflow
  fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) (#7738)
  fix(editor): Remove `n8nHooksNext` flag (no-changelog) (#7733)
  ...
@MiloradFilipovic
⚡ Reverting front-end validation, updating custom validator middlewar…
a735acb 
…e to test for URLs
@MiloradFilipovic
🔥 Removing leftover code
7fba46d
@netroy
add unit tests for customValidators
4f2d6ce
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 2064f7f into master Nov 22, 2023
59 of 60 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-1322-fix-name-field-code-injection branch November 22, 2023 11:14
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Merged
ivov added a commit that referenced this pull request Nov 22, 2023
@github-actions @ivov
🚀 Release 1.18.0 (#7780)
e01617a 
#
[1.18.0](https://github.com/n8n-io/n8n/compare/n8n@1.17.0...n8n@1.18.0)
(2023-11-22)


### Bug Fixes

* **core:** Account for non-ASCII chars in filename on binary data
download ([#7742](#7742))
([b4ebb1a](b4ebb1a))
* **core:** Correct permissions for getstatus
([#7724](#7724))
([f96c1d2](f96c1d2))
* **core:** Ensure failed executions are saved in queue mode
([#7744](#7744))
([b7c5c74](b7c5c74))
* **core:** Guard against node not found on cancelling test webhook
([#7750](#7750))
([6be453b](6be453b))
* **editor:** Handle permission edge cases (empty scopes)
([#7723](#7723))
([e2ffd39](e2ffd39))
* **editor:** Make sure LineController is registered with chart.js
([#7730](#7730))
([ebee1a5](ebee1a5))
* **editor:** Move workerview entry into settings menu
([#7761](#7761))
([366cd67](366cd67))
* **editor:** Only show push to git menu item to owners
([#7766](#7766))
([0d3d33d](0d3d33d))
* **editor:** Show v1 banner dismiss button if owner
([#7722](#7722))
([44d3b3e](44d3b3e))
* **editor:** Use project diagram icon for worker view
([#7764](#7764))
([ff0b651](ff0b651))
* **editor:** Validate user info before submiting
([#7608](#7608))
([2064f7f](2064f7f))
* **GitHub Node:** Fix issue preventing file edits on branches
([#7734](#7734))
([ce002a6](ce002a6))
* **Google Sheets Node:** Check for `null` before destructuring
([#7729](#7729))
([5d4a52d](5d4a52d))
* **Item Lists Node:** Don't check same type in remove duplicates
operation ([#7678](#7678))
([4f30764](4f30764))
* **JotForm Trigger Node:** Fix iteration on form loader
([#7751](#7751))
([82f3202](82f3202))


### Features

* Add Creator hub link to Templates page
([#7721](#7721))
([4dbae0e](4dbae0e))
* **core:** Coordinate manual workflow activation and deactivation in
multi-main scenario ([#7643](#7643))
([4c40825](4c40825))
* **editor:** Add node context menu
([#7620](#7620))
([8d12c1a](8d12c1a))
* **editor:** Node IO filter
([#7503](#7503))
([1881765](1881765))

Co-authored-by: ivov <ivov@users.noreply.github.com>
MiloradFilipovic added a commit that referenced this pull request Nov 22, 2023
@MiloradFilipovic
Merge branch 'master' into ADO-1241-collaboration-avatars
f8ba425 
* master:
  🚀 Release 1.18.0 (#7780)
  fix(core): Pass correct node reference to NodeExecuteFunctions.getLoadOptionsFunctions (no-changelog) (#7779)
  docs: Add workflow template contribution to the contributing guide (#7777)
  fix(editor): Validate user info before submiting (#7608)
  feat(core): Make postgres pool-size configurable (no-changelog) (#7772)
  refactor(core): Include execution progress in save settings (no-changelog) (#7769)
  refactor: Upgrade to TypeScript 5.3 (no-changelog) (#7768)
  fix(editor): Only show push to git menu item to owners (#7766)
  fix(editor): Use project diagram icon for worker view (#7764)
  fix(Item Lists Node): Don't check same type in remove duplicates operation (#7678)
  fix(editor): Move workerview entry into settings menu (#7761)
  fix(core): Ensure failed executions are saved in queue mode (#7744)
  docs: Update docs links for data transformation functions and ifEmpty (#7758)
  feat(editor): Add node context menu (#7620)
@janober
Copy link
Member

janober commented Nov 22, 2023

Got released with n8n@1.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

@mutdmour mutdmour mutdmour left review comments

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MiloradFilipovic @janober @netroy @mutdmour