-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attaching Gmail draft to a thread using the threadId parameter #8194
Conversation
Hey @Nicolas-nwb, On it's own the initial PR looked to be great but the alias feature that has been added in as well will need some testing to work out if we need to change anything when it comes to using service accounts. |
@Joffcom Thank you for watching. Sorry, this is my first contribution to an open source project on Github. Indeed, I have not taken into account or tested the alias functionality with service accounts. |
Hey @Nicolas-nwb, The thread draft feature you developed is amazing. Would you consider submitting this standalone feature again while you're working on the alias feature? |
Thank you @zhengyishen0. This is my first contribution on Github and I'm not sure if I understood how to submit the two features separately. I thought my work was done and that the merge required a final approval from a community member. Since I don't have a Gmail service account, I can't verify the functionality of the alias feature. I would like my request to be merged, but I don't know what I need to do to move things forward. |
Oh man, the thread draft feature is a must! THANK YOU! Was surprised it's not available initially. Would love standalone to be added to the main soon so people don't have to fork :( @Nicolas-nwb P.S Is there anyway to do it through a code node in the meantime ? |
@russkiimike In the meantime, I am using this custom public image neoroth/n8n:base which integrates the functionality of drafts in Gmail threads as well as the ability to select the sender's address if you have multiple sending accounts. Custom neoroth/n8n:base image |
Hi Nicolas,
This custom docker image is very helpful as well. Hope the n8n team will
soon integrate your contribution into the official release.
…On Sat, Feb 3, 2024 at 10:20 AM Nicolas-nwb ***@***.***> wrote:
@russkiimike <https://github.com/russkiimike> In the meantime, I am using
this custom public image *neoroth/n8n:base* which integrates the
functionality of drafts in Gmail threads as well as the ability to select
the sender's address if you have multiple sending accounts. Custom
neoroth/n8n:base image <https://hub.docker.com/r/neoroth/n8n>
I will continue to regularly update this image while waiting for the
changes to be integrated.
—
Reply to this email directly, view it on GitHub
<#8194 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3GB5SY2LNDAAUASJ4G4JODYRZIS7AVCNFSM6AAAAABBJLHX5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGM2TONBQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Nicolas-nwb Is there a way to access it as a node ? Cause reinstalling the whole system is tricky. OR via request node ? I am trying to figure out if it's enough to just POST the following to drafts ? Added the same subject to the email body and base64 encoded as per docs but it just seems to create a blank draft, not attached to threadID
|
This could be merged this week if the alias part was removed and added as a different PR, We like to keep the PRs specific to what they are doing to make it easier to track down where issues come from. |
@Nicolas-nwb Can you split the PR's please ? |
Hello, I'm sorry, but unfortunately I still don't know how to split the PRs. I'm also very busy this week and won't have time to look into it. If someone is available to help me, that would be greatly appreciated. Otherwise, I will look into it next week as soon as I have a moment. Thank you very much for your understanding. Sincerely, |
Oh Cool @Joffcom @Nicolas-nwb Does this mean it's been approved ? Just needs a docker update ? |
There, I believe I have managed to split the 2 PRs. I did it as quickly as possible and I hope it was not done at the expense of quality. |
Summary
This pull request solves an issue where drafts created via the Gmail API were not properly attached to an existing thread. Previously, drafts were created independently, without any connection to ongoing conversations. With this update, by passing the thread ID (threadId) during the creation of the draft, the draft is now correctly attached to the specified thread.
Related tickets and issues
Add Thread ID to gMail node Draft Resource
To test
Tests
A pre-built image with this functionality is available here : neoroth/n8n:custom-base
The functionality has been tested manually.
Review / Merge checklist
(no-changelog)
otherwise. (conventions)