Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Fix typos in common error messages (no-changelog) #9478

Merged
merged 2 commits into from
May 22, 2024
Merged

fix(core): Fix typos in common error messages (no-changelog) #9478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72f5a5f
🐛 Fix typos in common error messages
pemontto May 21, 2024
0a2903e
Fix tests for new error message
pemontto May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/workflow/src/errors/abstract/node.error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@ const COMMON_ERRORS: IDataObject = {
// nodeJS errors
ECONNREFUSED: 'The service refused the connection - perhaps it is offline',
ECONNRESET:
'The connection to the server wes closed unexpectedly, perhaps it is offline. You can retry request immidiately or wait and retry later.',
'The connection to the server was closed unexpectedly, perhaps it is offline. You can retry the request immediately or wait and retry later.',
ENOTFOUND:
'The connection cannot be established, this usually occurs due to an incorrect host(domain) value',
'The connection cannot be established, this usually occurs due to an incorrect host (domain) value',
ETIMEDOUT:
"The connection timed out, consider setting 'Retry on Fail' option in the node settings",
"The connection timed out, consider setting the 'Retry on Fail' option in the node settings",
ERRADDRINUSE:
'The port is already occupied by some other application, if possible change the port or kill the application that is using it',
EADDRNOTAVAIL: 'The address is not available, ensure that you have the right IP address',
ECONNABORTED: 'The connection was aborted, perhaps the server is offline',
EHOSTUNREACH: 'The host is unreachable, perhaps the server is offline',
EAI_AGAIN: 'The DNS server returned an error, perhaps the server is offline',
ENOENT: 'The file or directory does not exist',
EISDIR: 'The file path expected but a given path is a directory',
ENOTDIR: 'The directory path expected but a given path is a file',
EISDIR: 'The file path was expected but the given path is a directory',
ENOTDIR: 'The directory path was expected but the given path is a file',
EACCES: 'Forbidden by access permissions, make sure you have the right permissions',
EEXIST: 'The file or directory already exists',
EPERM: 'Operation not permitted, make sure you have the right permissions',
Expand Down
4 changes: 2 additions & 2 deletions packages/workflow/test/NodeErrors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,15 @@ describe('NodeErrors tests', () => {
const nodeOperationError = new NodeOperationError(node, 'ENOTFOUND test error message');

expect(nodeOperationError.message).toEqual(
'The connection cannot be established, this usually occurs due to an incorrect host(domain) value',
'The connection cannot be established, this usually occurs due to an incorrect host (domain) value',
);
});

it('should return default message for ENOTFOUND, NodeApiError', () => {
const nodeApiError = new NodeApiError(node, { message: 'ENOTFOUND test error message' });

expect(nodeApiError.message).toEqual(
'The connection cannot be established, this usually occurs due to an incorrect host(domain) value',
'The connection cannot be established, this usually occurs due to an incorrect host (domain) value',
);
});

Expand Down
Loading