fix: Don't throw errors for NaN in number operators in the filter component #9506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
MiloradFilipovic
approved these changes
May 24, 2024
|
|
2 flaky tests on run #5175 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9506 ↗︎
…number-but-was-expecting-a
…number-but-was-expecting-a
michael-radency
approved these changes
May 29, 2024
|
|
…number-but-was-expecting-a
michael-radency
approved these changes
May 30, 2024
|
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-1369-filter-node-wrong-type-nan-is-a-number-but-was-expecting-a
branch
Merged
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
May 31, 2024
* master: fix(editor): Fix ts errors across the board (no-changelog) (#9561) refactor(core): Extract all Auth-related User columns into a separate entity (#9557) refactor(core): Update supertest, and fix some typing errors (no-changelog) (#9527) fix(editor): Render checkboxes in markdown (#9549) test(core): Rename and combine all credential api tests (no-changelog) (#9550) 🚀 Release 1.44.0 (#9553) feat(editor): Node Creator AI nodes improvements (#9484) fix(editor): Show workflow data in header when execution page is hard reloaded (#9529) refactor(core): Stop reporting to Sentry `NodeApiError` with 5xx status codes (no-changelog) (#9552) feat: HighLevel oauth2 api credentials (#9542) fix(editor): Fix empty node name handling (#9548) ci: Fix vulnerable dev dependencies (no-changelog) (#9545) fix: Don't throw errors for NaN in number operators in the filter component (#9506) fix(core): Try setting postgres search_path on the database (#9530) fix(editor): Redirect to workflows list after deleting a workflow (#9546) # Conflicts: # packages/editor-ui/src/views/NodeView.vue # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Display NaN as
NaNinstead ofnullAllow NaN in number operators (don't throw)
Related tickets and issues
https://linear.app/n8n/issue/NODE-1369/filter-node-wrong-type-nan-is-a-number-but-was-expecting-a-number
https://community.n8n.io/t/filter-is-a-number-but-was-expecting-a-number/46448
Review / Merge checklist
(no-changelog)otherwise. (conventions)