Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Telegram Node): Add support to Keyboard Button Mini Apps #9511

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat(Telegram Node): Add support to Keyboard Button Mini Apps #9511

merged 1 commit into from
Jul 10, 2024

Conversation

stanleytakamatsu
Copy link
Contributor

@stanleytakamatsu stanleytakamatsu commented May 24, 2024 •
edited
Loading

Summary

Currently, Telegram Node does not support Keyboard Button Mini Apps.
This PR aims to enable the use of Mini App features in Reply Keyboard and Inline Reply Keyboard.

Reply Keyboard

image

Screenrecorder-2024-05-24-13-58-13-499.mp4

Inline Reply Keyboard

image

Screenrecorder-2024-05-24-13-59-59-786.mp4

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@CLAassistant
Copy link

CLAassistant commented May 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request ui Enhancement in /editor-ui or /design-system in linear Issue or PR has been created in Linear for internal review labels May 24, 2024
@stanleytakamatsu stanleytakamatsu force-pushed the feat/add-support-to-reply-with-web-app-url branch from a91709d to d7f9e27 Compare May 24, 2024 20:05
@stanleytakamatsu
Copy link
Contributor Author

What else would be necessary for this Pull Request to be reviewed?

Thanks

@stanleytakamatsu stanleytakamatsu force-pushed the feat/add-support-to-reply-with-web-app-url branch from d7f9e27 to 8cfbf75 Compare June 22, 2024 05:06
@stanleytakamatsu stanleytakamatsu force-pushed the feat/add-support-to-reply-with-web-app-url branch from 8cfbf75 to 1a4bff6 Compare June 22, 2024 05:10
Joffcom
Joffcom approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, Thanks for the contribution.

@Joffcom Joffcom changed the title feat(Telegram node): Add support to Keyboard Button Mini Apps feat(Telegram Node): Add support to Keyboard Button Mini Apps Jul 10, 2024
@Joffcom Joffcom merged commit 3a17943 into n8n-io:master Jul 10, 2024
8 of 10 checks passed
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
@janober
Copy link
Member

janober commented Jul 10, 2024

Got released with n8n@1.50.0

jeanpaul pushed a commit that referenced this pull request Jul 11, 2024
@stanleytakamatsu @jeanpaul
feat(Telegram Node): Add support to Keyboard Button Mini Apps (#9511)
e4f59ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcnaveen mcnaveen mcnaveen left review comments

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stanleytakamatsu @CLAassistant @janober @Joffcom @mcnaveen