feat(Merge Node): Overhaul, v3 #9528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
node/improvement
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
…merge-node-overhaul-v3
ShireenMissi
reviewed
Jul 1, 2024
| }); | ||
| } | ||
|
|
||
| const inputData = inputsData[parseInt(String(useDataOfInput)) - 1]; |
There was a problem hiding this comment.
you could get rid of the parsing and just use useDataOfInput as it's already of type Number
packages/nodes-base/nodes/Merge/v3/actions/mode/combineBySql.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
nice job adding unit tests 🎉
| const nodeParameters: IDataObject = { | ||
| operation: 'combineBySql', | ||
| query: | ||
| 'SELECT *, input1.data as data_1\nFROM input1\nLEFT JOIN input2\nON input1.id = input2.id\n', |
There was a problem hiding this comment.
could you add a test for invalid SQL input
| parameters: {}, | ||
| }; | ||
|
|
||
| const inputsData = [ |
There was a problem hiding this comment.
what happens if the input is invalid? could you add test cases for that?
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
…merge-node-overhaul-v3
|
|
3 flaky tests on run #5740 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo renaming node using NDV |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9528 ↗︎
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support for multiple inputs(#8975), SQL mode, and some smaller improvements
Related tickets and issues
https://linear.app/n8n/issue/NODE-1348/merge-node-overhaul