Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GitHub Node): Add support for state reasons when editing an issue #9848

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jun 24, 2024

Summary

Found on the forum and it is a quick win. Adds State Reason which lets you set closed as completed, closed as not planned and reopened.

image

Related Linear tickets, Github issues, and Community forum posts

https://community.n8n.io/t/github-node-close-issue-as-not-planned/48801

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jun 24, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 1, 2024

2 flaky tests on run #5728 ↗︎

0 395 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: 61513856b1
Status: Passed Duration: 04:32 💡
Started: Jul 1, 2024 12:34 PM Ended: Jul 1, 2024 12:39 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll Test Replay Screenshots Video

Review all test suite changes for PR #9848 ↗︎

@Joffcom Joffcom merged commit 61c20d1 into master Jul 2, 2024
27 checks passed
@Joffcom Joffcom deleted the forum-48801 branch July 2, 2024 13:40
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with n8n@1.49.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants